make PR type box list "fancier" without making it a github tasklist

[ithinuel]

Description

This basically make the default PR template looks like this PR.

Pull request type

[ ] Fix  
[x] Refactor  
[ ] New target  
[ ] Feature  
[ ] Breaking change

[0xc0170]

Not certain about the note, is it necessary ? A user should not change the format. Why we do not have - there should be in git history (we changed it to the format its now)

[adbridge]

I'm not sure this is actually adding anything. Use of a 'X' or 'x' is probably hard to mandate and any automated checking we apply will allow for both.

[adbridge]

Also I don't think the note is necessary. We already have a comment saying do not change the layout.

[ithinuel]

Everytime I create a PR and see these boxes I'm tempted to create the kind of box list I know.
The choice of not using them it not obvious (to me) at a first glance.

@adbridge It's not much about the x or X but on the monospaced box list or markdown task list.

[X] like
[ ] that

or

• like
• that

Writing the later one would make the PR have a "todo" list displayed that we do not want.

[ithinuel]

@adbridge I removed the note move the explanation closer to where we ask not to change the layout.

[adbridge]

@ithinuel Either way to get either of the changes you mention would mean somebody has changed the layout ..... Which we already tell them not to do. We 'could' update the note to say something like.
"Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front of them would change the meaning incorrectly. The only changes to be made to this PR header are to add a description text under the description heading and to add a 'x' to the correct box."

[ithinuel]

Would this last update be Ok ?

[adbridge]

LGTM :)

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 1795
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6669/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1444
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6669/

[mbed-ci]

Test : FAILURE

Build number : 1605
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6669/1605

[0xc0170]

@kjbracey-arm @mikaleppanen Can you review the latest test result (related to echo test). We noticed this failure, seldom in the last days.

/morph test

[mbed-ci]

Test : SUCCESS

Build number : 1612
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6669/1612

[0xc0170]

@kjbracey-arm @mikaleppanen Can you review the latest test result (related to echo test). We noticed this failure, seldom in the last days.

Not networking , I missed the driver test in there. Never-mind, drivers /host issue.