New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EFR32 15.4 driver #6701

Merged
merged 2 commits into from Apr 25, 2018

Conversation

Projects
None yet
6 participants
@stevew817
Contributor

stevew817 commented Apr 23, 2018

Description

  • Updates driver library to v2.3.1 (2018q1) for bugfixes and convenience functions
  • Provides library in correct format (2-byte wchar_t flag) for compiling with ARMCC (bug #6695 uncovered by PR #6577)
  • Reverts to using a statically-allocated packet buffer since malloc is not thread-safe (and the asserts have been turned on)

Tested using mbed OS client example over Thread, both with GCC and armcc.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Update to EFR32 15.4 driver
* Updates driver library to v2.3.1 (2018q1) for bugfixes and convenience functions
* Provides library in correct format (2-byte wchar_t flag) for compiling with ARMCC (#6695 uncovered by #6577)
* Reverts to using a statically-allocated packet buffer since malloc is not thread-safe (and the asserts have been turned on)
@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Apr 23, 2018

Bunch of source files have been marked executable here.

@0xc0170 0xc0170 requested a review from SeppoTakalo Apr 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 23, 2018

Should we add readme to the rail library what toolchain versions were used to generate it?

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Apr 23, 2018

@0xc0170 and @kjbracey-arm What is the current guideline regarding binaries?

Most binaries provided within the Mbed OS are in toolchain specific targets TOOLCHAIN_ARM, TOOLCHAIN_GCC and TOOLCHAIN_IAR to avoid compatibility issues. This wchar_t is one, but can we trust that there are no others?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 23, 2018

This might be added to documentation.
I would recommend generating lib per toolchain to avoid surprises. This lib addition would be split in to own toolchain folders where each lib would reside. + document what versions of toolchain were used for each

@SeppoTakalo

Many test and lib files are marked executable:
librail_efr32xg1_release.a 100644 → 100755

(Hoever, seems to be case for quite a many files within Mbed OS tree. Can we accept it?)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 23, 2018

executable as shown above

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Apr 23, 2018

@0xc0170 @SeppoTakalo @kjbracey-arm File permissions fixed.

@SeppoTakalo

Thanks.

@cmonr cmonr added needs: CI and removed needs: work labels Apr 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 23, 2018

Build : SUCCESS

Build number : 1829
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6701/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

Echo is being fixed so will retrigger once the fix lands on master (waiting for one last CI to complete)

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 24, 2018

/morph test

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Apr 24, 2018

@cmonr You probably meant 5.8.4?

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 25, 2018

@0xc0170 0xc0170 merged commit 5ee2658 into ARMmbed:master Apr 25, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9423 cycles (+502 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment