Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to EFR32 15.4 driver #6701

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Update to EFR32 15.4 driver #6701

merged 2 commits into from
Apr 25, 2018

Conversation

stevew817
Copy link
Contributor

Description

Tested using mbed OS client example over Thread, both with GCC and armcc.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@stevew817
Update to EFR32 15.4 driver
c0ee42a 
* Updates driver library to v2.3.1 (2018q1) for bugfixes and convenience functions
* Provides library in correct format (2-byte wchar_t flag) for compiling with ARMCC (ARMmbed#6695 uncovered by ARMmbed#6577)
* Reverts to using a statically-allocated packet buffer since malloc is not thread-safe (and the asserts have been turned on)
This was referenced Apr 23, 2018
Merged
Closed
@kjbracey
Copy link
Contributor

Bunch of source files have been marked executable here.

0xc0170
0xc0170 previously approved these changes Apr 23, 2018
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 23, 2018

Should we add readme to the rail library what toolchain versions were used to generate it?

@SeppoTakalo
Copy link
Contributor

@0xc0170 and @kjbracey-arm What is the current guideline regarding binaries?

Most binaries provided within the Mbed OS are in toolchain specific targets TOOLCHAIN_ARM, TOOLCHAIN_GCC and TOOLCHAIN_IAR to avoid compatibility issues. This wchar_t is one, but can we trust that there are no others?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 23, 2018

This might be added to documentation.
I would recommend generating lib per toolchain to avoid surprises. This lib addition would be split in to own toolchain folders where each lib would reside. + document what versions of toolchain were used for each

SeppoTakalo
SeppoTakalo suggested changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many test and lib files are marked executable:
librail_efr32xg1_release.a 100644 → 100755

(Hoever, seems to be case for quite a many files within Mbed OS tree. Can we accept it?)

@0xc0170 0xc0170 dismissed their stale review April 23, 2018 08:23

executable as shown above

@stevew817
Copy link
Contributor Author

@0xc0170 @SeppoTakalo @kjbracey-arm File permissions fixed.

SeppoTakalo
SeppoTakalo approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cmonr
Copy link
Contributor

cmonr commented Apr 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Build : SUCCESS

Build number : 1829
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6701/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Exporter Build : FAILURE

Build number : 1472
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6701/

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Test : FAILURE

Build number : 1634
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6701/1634

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Exporter Build : SUCCESS

Build number : 1477
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6701/

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Test : FAILURE

Build number : 1639
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6701/1639

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

Echo is being fixed so will retrigger once the fix lands on master (waiting for one last CI to complete)

@cmonr
Copy link
Contributor

cmonr commented Apr 24, 2018

/morph test

@stevew817
Copy link
Contributor Author

@cmonr You probably meant 5.8.4?

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

Test : SUCCESS

Build number : 1650
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6701/1650

@0xc0170 0xc0170 merged commit 5ee2658 into ARMmbed:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stevew817 @kjbracey @0xc0170 @SeppoTakalo @cmonr @mbed-ci