Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with MBED_MEM_TRACING_ENABLED and ARMC6 #6762

Merged
merged 1 commit into from
May 3, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 27, 2018

Description

This PR tries to fix the compile error. Take mbed-os-example-blinky for example. If I compile with:

mbed compile -m NUMAKER_PFM_NUC472 -t ARMC6 -DMBED_MEM_TRACING_ENABLED=1

I meet error with:

Compile [ 77.1%]: mbed_interface.c
Compile [ 77.3%]: mbed_mem_trace.cpp
Compile [ 77.6%]: mbed_poll.cpp
Compile [ 77.8%]: mbed_sdk_boot.c
Compile [ 78.1%]: mbed_retarget.cpp
[ERROR] .\mbed-os\platform\mbed_retarget.cpp:1390:10: fatal error: 'reent.h' file not found
#include <reent.h>
         ^~~~~~~~~
1 error generated.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2018

Our CI runs still with ARMC5 (I recall if you do a PR for ARMC6 feature branch then it would run for that one). Is that good to land this one on master (how to test?) @theotherjimmy please review

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 27, 2018

@0xc0170 I didn't send a PR for ARMC6 feature branch before. This error was found on my port for NUMAKER_PFM_M2351 target.

@theotherjimmy
Copy link
Contributor

@0xc0170 I ran it locally. works. No warnings 😮

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to go to master with this.

@theotherjimmy
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2018

Build : SUCCESS

Build number : 1874
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6762/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 28, 2018

@adbridge
Copy link
Contributor

Both the test failures appear to be due to infrastructure issues. Re-running:
/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants