-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common define MBED_ALL_STATS_ENABLED to enable all statistics #6784
Conversation
12ee317
to
c98cfdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how the block is repeated multiple times, can we find a one place to do it? Config file would be good I guess.
c98cfdd
to
0bfad60
Compare
@bulislaw @0xc0170 - I am confused with the usage of Stack and Heap macro. In case of stack we check if it is defined and true (https://github.com/ARMmbed/mbed-os/blob/master/rtos/TARGET_CORTEX/mbed_rtx_conf.h#L48) but in case of heap we just check if it is defined (https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_alloc_wrappers.cpp#L49). What is the correct behavior and should we have it consistent to both? |
What does our documentation says? I don't think it matters but id rather have it consistent. |
As part of Device Health requirement, all mbed OS statistics should be enabled with single macro `MBED_ALL_STATS_ENABLED`
0bfad60
to
5a1c832
Compare
@studavekar - morph build and test is done with Please note few new features will come in with |
All STATS flag can start becoming unmanageable as we start adding more stats like CPU stats, errors etc. But I still would like to enable everything in one shot. Can we capture this using configuration system or may be in the mbedcli command line parser itself. |
As I understand this: If it was
Config named |
Defines are set as part of command line only |
👍 Updated based on similar understanding |
That would be a nice addition, we are currently have all these set as |
@0xc0170 @deepikabhavnani - Well, I was thinking lets make the ALL Stats flag as MBED_CONF_ flag which can be used through config system. So, the preferred way ALL_STATS flag is enabled is through our config system. So, that we don't have to sprinkle that in our code multiple places. |
Even if we append flags with |
@SenRamakri You do not nee an |
@deepikabhavnani The config system does not include anything about dependencies. It was designed to avoid the dependency resolution problem. |
rtos/TARGET_CORTEX/mbed_rtx_conf.h
Outdated
@@ -45,7 +45,11 @@ | |||
#error "OS Tickrate must be 1000 for system timing" | |||
#endif | |||
|
|||
#if !defined(OS_STACK_WATERMARK) && (defined(MBED_STACK_STATS_ENABLED) && MBED_STACK_STATS_ENABLED) | |||
#if !defined(OS_STACK_WATERMARK) && defined(MBED_STACK_STATS_ENABLED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it duplicated? Can we use #if !defined(OS_STACK_WATERMARK) && (defined(MBED_ALL_STATS_ENABLED) || defined(MBED_STACK_STATS_ENABLED))
All API header files should be part of mbed.h
5a1c832
to
52c33b5
Compare
@bulislaw @0xc0170 @SenRamakri - Please review |
/morph build |
Build : SUCCESSBuild number : 1969 Triggering tests/morph test |
Test : SUCCESSBuild number : 1782 |
Exporter Build : FAILUREBuild number : 1620 |
Retry export build /morph export-build |
Exporter Build : SUCCESSBuild number : 1621 |
Description
Requirement: All mbed OS statistics should be enabled with single macro
MBED_ALL_STATS_ENABLED
Pull request type
CC @SenRamakri