Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix LoRaMacCrypto asserts #6800

Merged
merged 1 commit into from
May 8, 2018
Merged

Lora: Fix LoRaMacCrypto asserts #6800

merged 1 commit into from
May 8, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented May 3, 2018

Description

If Lora stack is built with incorrect mbedtls settings, crypto methods
should assert and return error value. This fixes MBED_ASSERTs to
work correctly.

This is a fix for issue #6764.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

If Lora stack is built with incorrect mbedtls settings, crypto methods
should assert and return error value. This fixes MBED_ASSERTs to
work correctly.
@kivaisan
Copy link
Contributor Author

kivaisan commented May 3, 2018

@hasnainvirk @kjbracey-arm @AnttiKauppila please review.

@hasnainvirk
Copy link
Contributor

@kivaisan Can you please check why the CI became unstable ? @0xc0170 If its just CI not being available, can we re-run CI for this ?

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2018

jenkins CI - started failing yesterday afternoon, we are investigating the cause, might not be related to this changeset.

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

I restarted jenkins CI, should be green if all OK here. The CI issue was resolved.

@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1932
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6800/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr cmonr merged commit 11901f1 into ARMmbed:master May 8, 2018
@cmonr cmonr removed the needs: CI label May 8, 2018
@adbridge
Copy link
Contributor

This fix is on top of #6692 which is targeted for 5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants