Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export: Fix invalid config header path in Sw4STM32 #6838

Merged
merged 2 commits into from May 14, 2018
Merged

export: Fix invalid config header path in Sw4STM32 #6838

merged 2 commits into from May 14, 2018

Conversation

ajaakkoh
Copy link
Contributor

@ajaakkoh ajaakkoh commented May 8, 2018

Description

Removed tmp-path from config header path, when project is exported in online compiler. Fixes #5619

Parallel build is now enabled by default. In Windows build is terribly slow if parallel build is not enabled.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@ajaakkoh
export: Fix invalid config header path in Sw4STM32
03b16fc 
Removed tmp-path from config header path, when project is exported
in online compiler. Parallel build is enabled by default.
@0xc0170 0xc0170 requested a review from theotherjimmy May 8, 2018 11:08
@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2018

@ARMmbed/team-st-mcd Please review

@theotherjimmy
Copy link
Contributor

@ajaakko-arm Let me test this in the online compiler for you. BRB.

theotherjimmy
theotherjimmy reviewed May 8, 2018
View reviewed changes
tools/export/sw4stm32/__init__.py Outdated
config_header = self.toolchain.get_config_header()
if config_header:
config_header = relpath(config_header, self.resources.file_basepath[config_header])
print('Config header: ' + config_header)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a debug print.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That surely is, and shouldn't be there. I'll fix that.

@theotherjimmy
Copy link
Contributor

And I can't test it 😦 I'll see what I can do to get that back up.

theotherjimmy
theotherjimmy approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on patnerbeta. Works. Thanks!

@theotherjimmy
Copy link
Contributor

Please be aware that there will be a delay for getting this into the online compiler.

@0xc0170
Copy link
Contributor

0xc0170 commented May 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

Build : FAILURE

Build number : 1963
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6838/

@0xc0170
Copy link
Contributor

0xc0170 commented May 9, 2018

To confirm the failure. I fetched this locally, and was able to build one test. The changes do not touch ARM toolchain, neither the target. And just one example fails? Restarting

/morph build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

Build : SUCCESS

Build number : 1964
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6838/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

Test : SUCCESS

Build number : 1778
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6838/1778

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

Exporter Build : FAILURE

Build number : 1615
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6838/

@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

/morph export-build

3 similar comments
@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented May 11, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented May 14, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented May 14, 2018

@0xc0170 Might need you to kick the export build off.

@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Exporter Build : SUCCESS

Build number : 1646
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6838/

@cmonr cmonr merged commit 598e511 into ARMmbed:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajaakkoh @0xc0170 @theotherjimmy @mbed-ci @cmonr