New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: Fix invalid config header path in Sw4STM32 #6838

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
5 participants
@ajaakko-arm
Contributor

ajaakko-arm commented May 8, 2018

Description

Removed tmp-path from config header path, when project is exported in online compiler. Fixes #5619

Parallel build is now enabled by default. In Windows build is terribly slow if parallel build is not enabled.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
export: Fix invalid config header path in Sw4STM32
Removed tmp-path from config header path, when project is exported
in online compiler. Parallel build is enabled by default.

@0xc0170 0xc0170 requested a review from theotherjimmy May 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 8, 2018

@ARMmbed/team-st-mcd Please review

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 8, 2018

@ajaakko-arm Let me test this in the online compiler for you. BRB.

config_header = self.toolchain.get_config_header()
if config_header:
config_header = relpath(config_header, self.resources.file_basepath[config_header])
print('Config header: ' + config_header)

This comment has been minimized.

@theotherjimmy

theotherjimmy May 8, 2018

Contributor

This looks like a debug print.

This comment has been minimized.

@ajaakko-arm

ajaakko-arm May 9, 2018

Contributor

That surely is, and shouldn't be there. I'll fix that.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 8, 2018

And I can't test it 😦 I'll see what I can do to get that back up.

@theotherjimmy

Tested on patnerbeta. Works. Thanks!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2018

Please be aware that there will be a delay for getting this into the online compiler.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 9, 2018

To confirm the failure. I fetched this locally, and was able to build one test. The changes do not touch ARM toolchain, neither the target. And just one example fails? Restarting

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 9, 2018

Build : SUCCESS

Build number : 1964
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6838/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

/morph export-build

3 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 11, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 14, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 14, 2018

@0xc0170 Might need you to kick the export build off.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 14, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 14, 2018

@cmonr cmonr merged commit 598e511 into ARMmbed:master May 14, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9629 cycles (+87 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment