Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RTC on MCUXpresso devices #6912

Merged

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented May 15, 2018

Updates to the MCUXpresso RTC drivers per new RTC HAL specification.

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

@0xc0170 Could you help add commit 43d0f17 to this branch.

@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2018

@0xc0170 Could you help add commit 43d0f17 to this branch.

@c1728p9 Can you check and rebase the destination branch please?

@mmahadevan108 We shall wait for this rebase to start CI?

@cmonr
Copy link
Contributor

cmonr commented May 21, 2018

Will wait on rebase.

Also, this PR really should have a description, even if the fix is tiny...

@mmahadevan108
Copy link
Contributor Author

I don't see any updates to this branch for rebase. Can you please confirm what I should do.

@cmonr
Copy link
Contributor

cmonr commented May 21, 2018

I don't rebase is the right term we should be using here.

I think what @0xc0170 is implying is that we should wait until @c1728p9 or someone else updates the target branch to pull in 43d0f17 to test against.

@bulislaw
Copy link
Member

Feature branch rebased, please rebase your PR.

Same MCUXpresso SDK driver used for Kinetis devices

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

Thanks, I have rebased the PR.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run CI.

@cmonr
Copy link
Contributor

cmonr commented May 23, 2018

Will do once the CI frees up. We're prioritizing PRs that need to be merged into master that are going into 5.9, specifically because of code freeze.

PRs that are 5.9 related but going into feature branches are getting lower priority.

@bulislaw
Copy link
Member

All the PRs that go to the feature branches are planned to go to master for 5.9. I'll create PRs from feature branches to master later today.

@bulislaw bulislaw merged commit 3eb6630 into ARMmbed:feature-hal-spec-rtc May 23, 2018
@mmahadevan108 mmahadevan108 deleted the feature-hal-spec-rtc branch October 2, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants