Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lora: Add greentea tests for LoRaRadio API #7005

Merged
merged 1 commit into from
May 31, 2018
Merged

Lora: Add greentea tests for LoRaRadio API #7005

merged 1 commit into from
May 31, 2018

Conversation

kivaisan
Copy link
Contributor

Description

This LoRaRadio test set adds basic tests which can be run with a single HW.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@AnttiKauppila @hasnainvirk please review.

hasnainvirk
hasnainvirk previously approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@hasnainvirk hasnainvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TESTS/lorawan/loraradio/README.md Outdated

You can use the following command to run tests:

`mbed test -n mbed-os-tests-lorawan-loraradio -m TARGET -t GCC_ARM -v --profile debug --app-config mbed-os/TESTS/lorawan/loraradio/mbed_app.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the json file. It can't be mbed_app.json

TESTS/lorawan/loraradio/main.cpp Outdated
#elif (MBED_CONF_APP_LORA_RADIO == SX1276)
#include "SX1276_LoRaRadio.h"
#else
#error [NOT_SUPPORTED] Requires parameters from mbed_app.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give it a name which you will choose (anything other than mbed_app.json)

@kivaisan
Copy link
Contributor Author

@hasnainvirk Renamed mbed_app.json as template_mbed_app.txt. Also changed [NOT SUPPORTED] error as more generic.

AnttiKauppila
AnttiKauppila previously approved these changes May 25, 2018
View reviewed changes
@AnttiKauppila
Copy link

@0xc0170 Can you trigger build for this?

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

/morph build

@0xc0170 0xc0170 requested a review from kjbracey May 28, 2018 10:44
@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2174
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7005/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Test : SUCCESS

Build number : 1962
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7005/1962

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Exporter Build : ABORTED

Build number : 1799
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7005/

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

Build number : 1809
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7005/

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

@OPpuolitaival Can you please review these tests additions?

Basically, these tests are here but we do not execute them or how can we in CI?

@kivaisan Are we always showing by default the debug command? I would go with the default one.

mbed test -n mbed-os-tests-lorawan-loraradio -m TARGET -t GCC_ARM -v --profile debug --app-config mbed-os/TESTS/lorawan/loraradio/template_mbed_app.txt

Lora: Add greentea tests for LoRaRadio API
4ba82c0 
This LoRaRadio test set adds basic tests which can be run with a single HW.
@kivaisan
Copy link
Contributor Author

kivaisan commented May 29, 2018 •
edited
Loading

Are we always showing by default the debug command? I would go with the default one.

Definitely. I removed the debug and verbose options from example command.

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2189
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7005/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Test : FAILURE

Build number : 1977
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7005/1977

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

Build number : 1816
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7005/

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

Test : SUCCESS

Build number : 1982
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7005/1982

@cmonr cmonr merged commit 26b5f97 into ARMmbed:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila left review comments

@hasnainvirk hasnainvirk hasnainvirk left review comments

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kivaisan @AnttiKauppila @0xc0170 @mbed-ci @OPpuolitaival @hasnainvirk @cmonr @adbridge