New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Add greentea tests for LoRaRadio API #7005

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
8 participants
@kivaisan
Contributor

kivaisan commented May 24, 2018

Description

This LoRaRadio test set adds basic tests which can be run with a single HW.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 24, 2018

@AnttiKauppila @hasnainvirk please review.

@kivaisan kivaisan force-pushed the kivaisan:loraradio_tests branch from c406042 to 9ca3489 May 24, 2018

You can use the following command to run tests:
`mbed test -n mbed-os-tests-lorawan-loraradio -m TARGET -t GCC_ARM -v --profile debug --app-config mbed-os/TESTS/lorawan/loraradio/mbed_app.json`

This comment has been minimized.

@hasnainvirk

hasnainvirk May 24, 2018

Contributor

rename the json file. It can't be mbed_app.json

#elif (MBED_CONF_APP_LORA_RADIO == SX1276)
#include "SX1276_LoRaRadio.h"
#else
#error [NOT_SUPPORTED] Requires parameters from mbed_app.json

This comment has been minimized.

@hasnainvirk

hasnainvirk May 24, 2018

Contributor

give it a name which you will choose (anything other than mbed_app.json)

@kivaisan kivaisan force-pushed the kivaisan:loraradio_tests branch from 9ca3489 to a4e5e79 May 25, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 25, 2018

@hasnainvirk Renamed mbed_app.json as template_mbed_app.txt. Also changed [NOT SUPPORTED] error as more generic.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented May 28, 2018

@0xc0170 Can you trigger build for this?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 28, 2018

@0xc0170 0xc0170 requested a review from kjbracey-arm May 28, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2174
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7005/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 requested a review from OPpuolitaival May 29, 2018

@0xc0170 0xc0170 added needs: review and removed needs: CI labels May 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

@OPpuolitaival Can you please review these tests additions?

Basically, these tests are here but we do not execute them or how can we in CI?

@kivaisan Are we always showing by default the debug command? I would go with the default one.

mbed test -n mbed-os-tests-lorawan-loraradio -m TARGET -t GCC_ARM -v --profile debug --app-config mbed-os/TESTS/lorawan/loraradio/template_mbed_app.txt

Lora: Add greentea tests for LoRaRadio API
This LoRaRadio test set adds basic tests which can be run with a single HW.

@kivaisan kivaisan force-pushed the kivaisan:loraradio_tests branch from a4e5e79 to 4ba82c0 May 29, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 29, 2018

Are we always showing by default the debug command? I would go with the default one.

Definitely. I removed the debug and verbose options from example command.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2189
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7005/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 30, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 30, 2018

@cmonr cmonr merged commit 26b5f97 into ARMmbed:master May 31, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 916 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9569 cycles (+497 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment