New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in a comment #7018
fix typo in a comment #7018
Conversation
/morph build |
Build : SUCCESSBuild number : 2186 Triggering tests/morph test |
Test : FAILUREBuild number : 1975 |
This failure is unrelated to the changes brought by this PR. |
/morph test |
Test : FAILUREBuild number : 1978 |
Exporter Build : SUCCESSBuild number : 1814 |
/morph test |
Test : FAILUREBuild number : 1983 |
/morph test |
Test : FAILUREBuild number : 1993 |
The tests are run on the base branch of this PR, with the PR being merged into it. No idea why CI is failing like this. I suspect this still has older tests that experience intermittent issues. @studavekar Ideas? |
rebased on top of the target branch |
Will run CI once it frees up from release builds. |
/morph build |
Build : SUCCESSBuild number : 2273 Triggering tests/morph test |
Halting CI builds until RC3 PRs are completed. Will resume after. |
/morph test |
Exporter Build : SUCCESSBuild number : 1903 |
Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able. |
b99152e
to
429c18c
Compare
@ithinuel Can you look at the pr-head issues? It appears as if something is being declared implicitly, but imo, this PR should not have caused anything to fail. FYI, @ARMmbed/mbed-os-maintainers might need to look into why pr-head failed on this a bit more closely. |
@cmonr indeed I forgot a flag while rebasing >< I fixed that in feature-hal-spec-sai-rebased on my fork so you can push it as the new PR head. |
429c18c
to
cabef4d
Compare
/morph build |
Build : SUCCESSBuild number : 2342 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1966 |
Test : SUCCESSBuild number : 2127 |
Description
This fixes a dirty copy&paste.
Pull request type