Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in a comment #7018

Merged
merged 1 commit into from Jun 14, 2018
Merged

fix typo in a comment #7018

merged 1 commit into from Jun 14, 2018

Conversation

ithinuel
Copy link
Member

Description

This fixes a dirty copy&paste.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7018/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

@ithinuel
Copy link
Member Author

This failure is unrelated to the changes brought by this PR.

@cmonr
Copy link
Contributor

cmonr commented May 29, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 31, 2018

@ithinuel
Copy link
Member Author

ithinuel commented May 31, 2018

@0xc0170 @cmonr Are the tests ran on a "merged" branch or on this specific head ?
So I need to rebase ?

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

The tests are run on the base branch of this PR, with the PR being merged into it. No idea why CI is failing like this. I suspect this still has older tests that experience intermittent issues.

@studavekar Ideas?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2018

@0xc0170 @cmonr Are the tests ran on a "merged" branch or on this specific head ?
So I need to rebase ?

I would recommend rebasing (if its older than a week or so) and we restart the test.

@ithinuel
Copy link
Member Author

ithinuel commented Jun 5, 2018

rebased on top of the target branch

@cmonr
Copy link
Contributor

cmonr commented Jun 5, 2018

Will run CI once it frees up from release builds.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2273
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7018/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 8, 2018

Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able.

@cmonr
Copy link
Contributor

cmonr commented Jun 12, 2018

@ithinuel Can you look at the pr-head issues? It appears as if something is being declared implicitly, but imo, this PR should not have caused anything to fail.

FYI, @ARMmbed/mbed-os-maintainers might need to look into why pr-head failed on this a bit more closely.

@ithinuel
Copy link
Member Author

@cmonr indeed I forgot a flag while rebasing >< I fixed that in feature-hal-spec-sai-rebased on my fork so you can push it as the new PR head.
I updated this PR to be on top of the new PR-head.

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

Build : SUCCESS

Build number : 2342
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7018/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

@cmonr cmonr merged commit 3cea5d4 into ARMmbed:feature-hal-spec-sai Jun 14, 2018
@ithinuel ithinuel deleted the feature-hal-spec-sai branch May 28, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants