Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

ccli8 · 2018-05-28T07:34:11Z

Description

This PR tries to adhere to reworked RTC spec to release with Mbed OS 5.9.

Targets

NUMAKER_PFM_NUC472
NUMAKER_PFM_M453
NUMAKER_PFM_M487
NUMAKER_PFM_NANO130

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

ccli8 · 2018-05-28T07:38:05Z

Greentea test

NUC472/ARM

+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
| target                 | platform_name      | test suite                           | result | elapsed_time (sec) | copy_method |
+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.28              | default     |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 33.87              | default     |
+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

M453/ARM

+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.79              | default     |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 31.61              | default     |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

M487/ARM

+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.76              | default     |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 35.02              | default     |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

NANO130/ARM

+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
| target                  | platform_name       | test suite                           | result | elapsed_time (sec) | copy_method |
+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.59              | default     |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 34.46              | default     |
+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

0xc0170 · 2018-05-28T08:48:40Z

Thanks, I can see this is targetting RTC feature branch. It will be merged to master soon, once its done, we shall redirect this to master, will report back once done

0xc0170 · 2018-05-28T12:48:51Z

Can you redirect this to master please?

After rtc_free, RTC gets inaccessible from CPU domain but keeps counting.

ccli8 · 2018-05-29T02:59:22Z

@0xc0170 I've done rebase onto master and change merge target branch to master.

0xc0170 · 2018-05-29T08:26:49Z

/morph build

ccli8 · 2018-05-29T08:28:14Z

@0xc0170 Please hold on this PR. This PR cannot pass the test mbed-os-tests-mbed_hal-rtc_reset. I will fix it soon.

ccli8 · 2018-05-29T09:27:30Z

Please hold on this PR. This PR cannot pass the test mbed-os-tests-mbed_hal-rtc_reset. I will fix it soon.

@0xc0170 Please continue on.

0xc0170 · 2018-05-29T10:21:20Z

I'll restart CI and have to abort the one I triggered a moment ago

ithinuel

LGTM

mbed-ci · 2018-05-29T13:22:48Z

Build : SUCCESS

Build number : 2188
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7031/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-29T14:46:58Z

Test : FAILURE

Build number : 1976
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7031/1976

cmonr · 2018-05-29T15:52:22Z

/morph build

cmonr · 2018-05-29T15:55:03Z

@bulislaw Checking with you to see if this needs to come in with 5.9.0-rc2 or 5.9.1.

This definitely came in too late for the last minute HAL effort last week, but I think this is based on those changes.

mbed-ci · 2018-05-29T16:41:47Z

Build : SUCCESS

Build number : 2190
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7031/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-29T20:37:24Z

Test : SUCCESS

Build number : 1979
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7031/1979

bulislaw

That's fix for RC2.

mbed-ci · 2018-05-29T21:36:15Z

Exporter Build : SUCCESS

Build number : 1815
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7031/

mbed-ci · 2018-05-29T21:36:16Z

Exporter Build : SUCCESS

Build number : 1815
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7031/

0xc0170 added needs: work do not merge labels May 28, 2018

ccli8 added 2 commits May 29, 2018 10:33

[Nuvoton] Power down RTC access from CPU domain in rtc_free

2cefe7d

After rtc_free, RTC gets inaccessible from CPU domain but keeps counting.

[Nuvoton] Add back RTC to device_has target configuration

ee7efb5

ccli8 force-pushed the nuvoton_5.9_rtc branch from a9513f2 to ee7efb5 Compare May 29, 2018 02:40

ccli8 changed the base branch from feature-hal-spec-rtc to master May 29, 2018 02:53

0xc0170 previously approved these changes May 29, 2018

View reviewed changes

0xc0170 requested a review from a team May 29, 2018 08:24

0xc0170 removed do not merge needs: work labels May 29, 2018

0xc0170 added the needs: CI label May 29, 2018

[Nuvoton] Fix RTC cannot cross reset cycle

6065e3a

ccli8 dismissed 0xc0170’s stale review via 6065e3a May 29, 2018 09:22

0xc0170 changed the title ~~[Nuvoton] Adhere to reworked RTC spec to release with Mbed OS 5.9~~ Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 May 29, 2018

ithinuel approved these changes May 29, 2018

View reviewed changes

cmonr added release-version: 5.9.1 do not merge and removed release-version: 5.9.1 labels May 29, 2018

cmonr removed the do not merge label May 29, 2018

bulislaw approved these changes May 29, 2018

View reviewed changes

cmonr added ready for merge release-version: 5.9.0-rc2 and removed needs: CI labels May 29, 2018

0xc0170 added release-version: 5.9.1 and removed release-version: 5.9.0-rc2 labels May 30, 2018

cmonr merged commit dbc42f6 into ARMmbed:master May 31, 2018

ccli8 deleted the nuvoton_5.9_rtc branch June 1, 2018 02:03

cmonr removed the ready for merge label Jun 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

ccli8 commented May 28, 2018 •

edited by 0xc0170

Loading

ccli8 commented May 28, 2018

0xc0170 commented May 28, 2018

0xc0170 commented May 28, 2018

ccli8 commented May 29, 2018

0xc0170 commented May 29, 2018

ccli8 commented May 29, 2018

ccli8 commented May 29, 2018

0xc0170 commented May 29, 2018

ithinuel left a comment

mbed-ci commented May 29, 2018

mbed-ci commented May 29, 2018

cmonr commented May 29, 2018

cmonr commented May 29, 2018

mbed-ci commented May 29, 2018

mbed-ci commented May 29, 2018

bulislaw left a comment

mbed-ci commented May 29, 2018

mbed-ci commented May 29, 2018

Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

Conversation

ccli8 commented May 28, 2018 • edited by 0xc0170 Loading

Description

Targets

Pull request type

ccli8 commented May 28, 2018

Greentea test

NUC472/ARM

M453/ARM

M487/ARM

NANO130/ARM

0xc0170 commented May 28, 2018

0xc0170 commented May 28, 2018

ccli8 commented May 29, 2018

0xc0170 commented May 29, 2018

ccli8 commented May 29, 2018

ccli8 commented May 29, 2018

0xc0170 commented May 29, 2018

ithinuel left a comment

Choose a reason for hiding this comment

mbed-ci commented May 29, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented May 29, 2018

Test : FAILURE

cmonr commented May 29, 2018

cmonr commented May 29, 2018

mbed-ci commented May 29, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented May 29, 2018

Test : SUCCESS

bulislaw left a comment

Choose a reason for hiding this comment

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

ccli8 commented May 28, 2018 •

edited by 0xc0170

Loading