New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 #7031

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
6 participants
@ccli8
Contributor

ccli8 commented May 28, 2018

Description

This PR tries to adhere to reworked RTC spec to release with Mbed OS 5.9.

Targets

  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487
  • NUMAKER_PFM_NANO130

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 28, 2018

Greentea test

NUC472/ARM

+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
| target                 | platform_name      | test suite                           | result | elapsed_time (sec) | copy_method |
+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.28              | default     |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 33.87              | default     |
+------------------------+--------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

M453/ARM

+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.79              | default     |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 31.61              | default     |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

M487/ARM

+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.76              | default     |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 35.02              | default     |
+----------------------+------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK

NANO130/ARM

+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
| target                  | platform_name       | test suite                           | result | elapsed_time (sec) | copy_method |
+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-rtc_time      | OK     | 14.59              | default     |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-rtc_time_conv | OK     | 34.46              | default     |
+-------------------------+---------------------+--------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK
@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

Thanks, I can see this is targetting RTC feature branch. It will be merged to master soon, once its done, we shall redirect this to master, will report back once done

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

Can you redirect this to master please?

ccli8 added some commits May 28, 2018

[Nuvoton] Power down RTC access from CPU domain in rtc_free
After rtc_free, RTC gets inaccessible from CPU domain but keeps counting.

@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton_5.9_rtc branch from a9513f2 to ee7efb5 May 29, 2018

@ccli8 ccli8 changed the base branch from feature-hal-spec-rtc to master May 29, 2018

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 29, 2018

@0xc0170 I've done rebase onto master and change merge target branch to master.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal May 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label May 29, 2018

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 29, 2018

@0xc0170 Please hold on this PR. This PR cannot pass the test mbed-os-tests-mbed_hal-rtc_reset. I will fix it soon.

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 29, 2018

Please hold on this PR. This PR cannot pass the test mbed-os-tests-mbed_hal-rtc_reset. I will fix it soon.

@0xc0170 Please continue on.

@0xc0170 0xc0170 changed the title from [Nuvoton] Adhere to reworked RTC spec to release with Mbed OS 5.9 to Nuvoton: Adhere to reworked RTC spec to release with Mbed OS 5.9 May 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

I'll restart CI and have to abort the one I triggered a moment ago

@ithinuel

LGTM

@mbed-ci

This comment has been minimized.

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2188
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7031/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 29, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 29, 2018

@bulislaw Checking with you to see if this needs to come in with 5.9.0-rc2 or 5.9.1.

This definitely came in too late for the last minute HAL effort last week, but I think this is based on those changes.

@cmonr cmonr removed the do not merge label May 29, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2190
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7031/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@bulislaw

That's fix for RC2.

@mbed-ci

This comment has been minimized.

1 similar comment
@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit dbc42f6 into ARMmbed:master May 31, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 915 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10231 cycles (+582 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_5.9_rtc branch Jun 1, 2018

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment