Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows pytest fixes #7078

Merged
merged 4 commits into from
Jun 4, 2018
Merged

Windows pytest fixes #7078

merged 4 commits into from
Jun 4, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented May 31, 2018

Description

In the process of narrowing down Windows Py3 compatibility issues, discovered that pytest is never actually run on Windows.

Ran pytest and corrected issues found.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested a review from theotherjimmy May 31, 2018 21:45
theotherjimmy
theotherjimmy reviewed May 31, 2018
View reviewed changes
tools/test/memap/parse_test.py Outdated
memap.parse(join(dirname(__file__), "arm.map"), "UARM")
assert memap.modules == PARSED_ARM_DATA

PARSED_DATA_OS_AGNOSTIC = dict()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a local, let's use lower case.

tools/test/memap/parse_test.py Outdated
@@ -35,7 +39,12 @@ def test_parse_armcc():
def test_parse_iar():
memap = MemapParser()
memap.parse(join(dirname(__file__), "iar.map"), "IAR")
assert memap.modules == PARSED_IAR_DATA

PARSED_DATA_OS_AGNOSTIC = dict()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case.

tools/test/memap/parse_test.py Outdated
@@ -49,9 +58,14 @@ def test_parse_iar():
def test_parse_gcc():
memap = MemapParser()
memap.parse(join(dirname(__file__), "gcc.map"), "GCC_ARM")
assert memap.modules == PARSED_GCC_DATA

PARSED_DATA_OS_AGNOSTIC = dict()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case

@cmonr
Copy link
Contributor Author

cmonr commented May 31, 2018

Output with current PR checked out in a Windows 7 machine:

============================= test session starts =============================
platform win32 -- Python 2.7.12, pytest-3.6.0, py-1.5.3, pluggy-0.6.0
rootdir: C:\Users\root\py3-tests\stock-tools\mbed-os-pr7078, inifile:
plugins: hypothesis-3.57.0
collected 92 items

tools\test\detect_targets_test.py .....                                  [  5%]
tools\test\build_api\build_api_test.py .......                           [ 13%]
tools\test\config\config_test.py .....................................   [ 53%]
tools\test\memap\memap_test.py ........................                  [ 79%]
tools\test\memap\parse_test.py .....                                     [ 84%]
tools\test\targets\target_test.py ...                                    [ 88%]
tools\test\test_api\test_api_test.py ..                                  [ 90%]
tools\test\toolchains\api_test.py ......                                 [ 96%]
tools\test\toolchains\arm_support_test.py ...                            [100%]

========================= 92 passed in 28.77 seconds ==========================

Beautiful.

@cmonr
Copy link
Contributor Author

cmonr commented May 31, 2018

@theotherjimmy 👍

@cmonr
Copy link
Contributor Author

cmonr commented Jun 1, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

Build : SUCCESS

Build number : 2221
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 2, 2018

Test : SUCCESS

Build number : 2010
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7078/2010

@mbed-ci
Copy link

mbed-ci commented Jun 2, 2018

Exporter Build : SUCCESS

Build number : 1846
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7078/

@cmonr
Copy link
Contributor Author

cmonr commented Jun 2, 2018

/morph uvisor-test

@cmonr cmonr mentioned this pull request Jun 3, 2018
Merged
@cmonr cmonr added the needs: CI label Jun 3, 2018
@cmonr
Copy link
Contributor Author

cmonr commented Jun 3, 2018

/morph uvisor-test

@cmonr cmonr merged commit d364d36 into ARMmbed:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmonr @mbed-ci @theotherjimmy @0xc0170