New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows pytest fixes #7078

Merged
merged 4 commits into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@cmonr
Contributor

cmonr commented May 31, 2018

Description

In the process of narrowing down Windows Py3 compatibility issues, discovered that pytest is never actually run on Windows.

Ran pytest and corrected issues found.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
memap.parse(join(dirname(__file__), "arm.map"), "UARM")
assert memap.modules == PARSED_ARM_DATA
PARSED_DATA_OS_AGNOSTIC = dict()

This comment has been minimized.

@theotherjimmy

theotherjimmy May 31, 2018

Contributor

Since this is a local, let's use lower case.

@@ -35,7 +39,12 @@ def test_parse_armcc():
def test_parse_iar():
memap = MemapParser()
memap.parse(join(dirname(__file__), "iar.map"), "IAR")
assert memap.modules == PARSED_IAR_DATA
PARSED_DATA_OS_AGNOSTIC = dict()

This comment has been minimized.

@theotherjimmy

theotherjimmy May 31, 2018

Contributor

lower case.

@@ -49,9 +58,14 @@ def test_parse_iar():
def test_parse_gcc():
memap = MemapParser()
memap.parse(join(dirname(__file__), "gcc.map"), "GCC_ARM")
assert memap.modules == PARSED_GCC_DATA
PARSED_DATA_OS_AGNOSTIC = dict()

This comment has been minimized.

@theotherjimmy

theotherjimmy May 31, 2018

Contributor

lower case

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

Output with current PR checked out in a Windows 7 machine:

============================= test session starts =============================
platform win32 -- Python 2.7.12, pytest-3.6.0, py-1.5.3, pluggy-0.6.0
rootdir: C:\Users\root\py3-tests\stock-tools\mbed-os-pr7078, inifile:
plugins: hypothesis-3.57.0
collected 92 items

tools\test\detect_targets_test.py .....                                  [  5%]
tools\test\build_api\build_api_test.py .......                           [ 13%]
tools\test\config\config_test.py .....................................   [ 53%]
tools\test\memap\memap_test.py ........................                  [ 79%]
tools\test\memap\parse_test.py .....                                     [ 84%]
tools\test\targets\target_test.py ...                                    [ 88%]
tools\test\test_api\test_api_test.py ..                                  [ 90%]
tools\test\toolchains\api_test.py ......                                 [ 96%]
tools\test\toolchains\arm_support_test.py ...                            [100%]

========================= 92 passed in 28.77 seconds ==========================

Beautiful.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 1, 2018

Build : SUCCESS

Build number : 2221
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 2, 2018

/morph uvisor-test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 3, 2018

/morph uvisor-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2018

@cmonr cmonr merged commit d364d36 into ARMmbed:master Jun 4, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8889 cycles (-711 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment