Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up source files in groups #71

Closed
wants to merge 2 commits into from

Conversation

omdathetkan
Copy link
Contributor

Note: Do not merge

Split up source files in three groups to make projects more friendly to use.
tree

If this is considered an improvement I will do a proper pull request to master.
Note that the KL25Z, LPC11U24 and LPC1347 did not have the --c99 setting for c files before, please verify if this is intended or not.

Split up source files in three groups to make project more friendly to use.
Note that the KL25Z, LPC11U24 and LPC1347 did not have the --c99 setting for c files before, please verify if this is intended or not.

Fix Output Name and Directory for LPC1114
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2013

Hello jorisa,

can you share what is inside those folders , a snapshot?
Shouldn't "hal" be a folder inside mbed? Like is on github a root folder mbed - (api,common,hal, target). Same separation of those files.

Splitting will definitely improve user experience.

Regards,
0xc0170

@omdathetkan
Copy link
Contributor Author

I'm grouping as follows:

+                if file.startswith("mbed\\common"):
+                    source_files['mbed'].append(f)
+                elif file.startswith("mbed\\targets"):
+                    source_files['hal'].append(f)
+                else:
+                    source_files['src'].append(f)

Right now it looks like this:
talltree
I figured this would be a good trade-off between a single flat list and completely reproducing the full folder structure. When I'm debugging something its usually either an app, the mbed api, or fixing something for a specific target.

@emilmont
Copy link
Contributor

Hi Joris,
thanks for this "pull request".

The only thing that is blocking me from accepting it immediately is that we want to handle more gracefully the case of exporting a simple program that does not contain the mbed library sources (actually the most common case). My understanding, just reading the code, is that the project will get two empty groups ("hal" and "mbed").
Can you add a check for an empty list in Jinja2 syntax?

Cheers,
Emilio

@omdathetkan
Copy link
Contributor Author

Will do! Could you comment on the fact whether all templates should contain the --c99 flag?
Right now some of them do, some of them don't and I don't know if this is on purpose.

@emilmont
Copy link
Contributor

Yes, all templates should contain the "--c99" flag for compatibility with the mbed build system:
https://github.com/mbedmicro/mbed/blob/master/workspace_tools/toolchains/arm.py#L60

@emilmont emilmont closed this Sep 19, 2013
bridadan pushed a commit that referenced this pull request Jun 21, 2016
Building tests and test specs
artokin pushed a commit to artokin/mbed-os that referenced this pull request Aug 23, 2017
… from e125164..d65b6b0

d65b6b0 Update unittests for nsdynmemlib API change (ARMmbed#71)
bc69b8b Disable CoAP duplicate message detection (ARMmbed#69)
ccb65f8 Change year 2017 to copyright (ARMmbed#68)
76490a7 Add option to join COAP multicast group (ARMmbed#67)
381d910 Register to multicast groups (ARMmbed#66)
dce323c Add transaction delete to CoAP service (ARMmbed#65)
feea33e Add option to select used socket interface (ARMmbed#63)
5a5c0f9 Merge pull request ARMmbed#62 from ARMmbed/coap_separation
0d26c00 Modifying file headers and Makefile  to adapt from libcoap to mbed-coap
d323c3a Fixing unit tests based on new coap library
d1a3d25 Modifying Makefile and source file based on new coap library

git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service
git-subtree-split: d65b6b0
artokin pushed a commit to artokin/mbed-os that referenced this pull request Aug 23, 2017
…9c..b731d95

b731d95 Clarify mutex type requirement (ARMmbed#77)
7c31aef bumb version number (ARMmbed#72)
75982fc fix dummydefine for mbed_trace_init (ARMmbed#71)
539b80c Update version number. (ARMmbed#69)
b0e09f9 output/ added to gitignore list (ARMmbed#66)
a5cce88 Added include_directories(${CMAKE_CURRENT_SOURCE_DIR}/) include to resolve compilation error for Linux. (ARMmbed#63)
d087dbb Ensure tr_array doesn't print <null> when len == 0 (ARMmbed#65)

git-subtree-dir: features/FEATURE_COMMON_PAL/mbed-trace
git-subtree-split: b731d954d111d92199b2a0402dc9a3d52f5d4a17
geky pushed a commit to geky/mbed that referenced this pull request Aug 25, 2018
Block size as uint32_t gave incorrect device size
linlingao added a commit to linlingao/mbed-os that referenced this pull request Jul 12, 2019
Update flash api to use exact same file as the one produced by flash …
pan- added a commit to pan-/mbed that referenced this pull request May 29, 2020
Readme updated with step by step expected visual result on the scanner.
pan- added a commit to pan-/mbed that referenced this pull request May 29, 2020
Fix reference to ST BLUENRG library.
artokin pushed a commit to artokin/mbed-os that referenced this pull request Aug 21, 2020
…es from 9441d65aab..063b1af74e

063b1af74e Convert files to unix format
e2b972d54b Merge pull request ARMmbed#72 from ARMmbed/sync_with_mbedos
05b490966f Flag chrono functions to support Mbed OS 5.15
b5296f000e (via Mbed-OS)Use std::chrono based functions
0eaa99b633 Fix error found by coverity (ARMmbed#71)

git-subtree-dir: connectivity/drivers/802.15.4_RF/stm-s2lp-rf-driver
git-subtree-split: 063b1af74e4eca7002d3b1c973a99d08feee37f8
Jookia pushed a commit to Jookia/mbed-os that referenced this pull request Mar 11, 2023
* First attempt at converting to OBJECT libraries.  Not working due to more object library limitations

* Only compile the main libraries as OBJECT, because that's all that CMake can be made to do right now.

* Fix availability of target-specific flags

* Missed some usages

* Fix some STM32 ethernet stuff that was not linking correctly

* More fixes for STM32 ethernet and weak symbols

* Fix prebuilt object file linking for MUSCA_S1

* Fix STM32 eth init license headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants