New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: check flags to make sure the IRK has been stored before retrieving it #7123

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Jun 5, 2018

Description

Fix for IRK and BDADDR being read in without checking the storage is valid. Found through a new clitest SM_whitelist_generation_test_01.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm requested review from pan- and donatieng Jun 5, 2018

@paul-szczepanek-arm paul-szczepanek-arm changed the title from check that flags have the IRK stored before retrieving it to BLE: check that flags have the IRK stored before retrieving it Jun 11, 2018

@paul-szczepanek-arm paul-szczepanek-arm changed the title from BLE: check that flags have the IRK stored before retrieving it to BLE: check flags to make sure the IRK has been stored before retrieving it Jun 11, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 11, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 11, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 11, 2018

Build : SUCCESS

Build number : 2318
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7123/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2018

@studavekar Can you review the test results? One target fails, but from logs - all is success, so why failed? Only one target, target issue?

Update: console shows it

greentea/mbed_greentea/mbed_report_api.py", line 557, in get_result_overlay_testcase_dropdown
23:24:50     datetime.datetime.fromtimestamp(testcase_result['time_start']).strftime('%d-%m-%Y %H:%M:%S.%f'),

A bug in greentea?

@pan-

pan- approved these changes Jun 12, 2018

@pan-

This comment has been minimized.

Member

pan- commented Jun 12, 2018

@0xc0170 The change in this PR do not impact the failing target; failure must be caused by something else.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 12, 2018

We're looking into some CI issues at the moment. The test will be restarted when the dust has settled.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 13, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 14, 2018

@cmonr cmonr merged commit c3e639a into ARMmbed:master Jun 14, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9266 cycles (-315 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment