Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: check flags to make sure the IRK has been stored before retrieving it #7123

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jun 5, 2018

Description

Fix for IRK and BDADDR being read in without checking the storage is valid. Found through a new clitest SM_whitelist_generation_test_01.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm changed the title check that flags have the IRK stored before retrieving it BLE: check that flags have the IRK stored before retrieving it Jun 11, 2018
@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: check that flags have the IRK stored before retrieving it BLE: check flags to make sure the IRK has been stored before retrieving it Jun 11, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 11, 2018

Build : SUCCESS

Build number : 2318
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7123/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 11, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2018

@studavekar Can you review the test results? One target fails, but from logs - all is success, so why failed? Only one target, target issue?

Update: console shows it

greentea/mbed_greentea/mbed_report_api.py", line 557, in get_result_overlay_testcase_dropdown
23:24:50     datetime.datetime.fromtimestamp(testcase_result['time_start']).strftime('%d-%m-%Y %H:%M:%S.%f'),

A bug in greentea?

@pan-
Copy link
Member

pan- commented Jun 12, 2018

@0xc0170 The change in this PR do not impact the failing target; failure must be caused by something else.

@cmonr
Copy link
Contributor

cmonr commented Jun 12, 2018

We're looking into some CI issues at the moment. The test will be restarted when the dust has settled.

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

@cmonr cmonr merged commit c3e639a into ARMmbed:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants