-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration options to enable CMAC in mbedtls by default #7144
Conversation
# Comments and uncomments #define lines in the given configuration header file | ||
# to configure the file for use in mbed OS. | ||
# | ||
# Usage: adjust-config.sh [path to config script] [path to no-entropy config file] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script name needs updating.
# | ||
# This file is part of mbed TLS (https://tls.mbed.org) | ||
# | ||
# Copyright (c) 2015-2018, ARM Limited, All Rights Reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright should be 2018.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Ok. Although, two different scripts are introduced for two different header files, while both scripts take file name as argument. Either single script should handle different files or filename argument should be removed for clear understanding of the scope of the script(s).
/morph build |
Build : ABORTEDBuild number : 2271 |
Odd. /morph build |
/morph build |
Build : ABORTEDBuild number : 2274 |
/morph build |
1 similar comment
/morph build |
Build : SUCCESSBuild number : 2280 Triggering tests/morph test |
1 similar comment
Build : SUCCESSBuild number : 2280 Triggering tests/morph test |
Test : SUCCESSBuild number : 2055 |
Exporter Build : SUCCESSBuild number : 1893 |
Description
This commit forces the CMAC feature to be enabled by default in Mbed TLS both in the regular and in the no-entropy configurations.
Warning! Currently the
MBEDTLS_CMAC_C
option is not present in the no-entropy config header, therefore the Mbed TLS scripting will append the option at the end of the file. This means the#define...
ends up after the#ifndef...
guard. This doesn't produce incorrect code, however is not perfect. A solution is to add (preferably commented out) CMAC define to the no-entropy configuration file upstream, which will make the scripting just uncomment the option making the code fully correct.Edit:
The MBEDTLS_CMAC_C Has been added upstream, therefore the define for the no-entropy config will no longer be placed outside the header guards.
Pull request type