New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct PPPCellularInterface::get_gateway() #7161

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
5 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Jun 7, 2018

Description

Two cascading copy-paste errors stopped this working:

  • PPPCellularInterface::get_gateway() called nsapi_ppp_get_ip_address();
  • nsapi_ppp_get_gateway() called the interface's get_netmask().

First bug has always been there - second one was introduced in 5.9.

AT_CellularNetwork currently lacks calls to get both netmask and gateway - this patch would be needed for that when added.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kjbracey-arm kjbracey-arm requested a review from TeemuKultala Jun 7, 2018

@0xc0170 0xc0170 added the needs: CI label Jun 7, 2018

Correct PPPCellularInterface::get_gateway()
Two cascading copy-paste errors stopped this working:

  * PPPCellularInterface::get_gateway() called
    nsapi_ppp_get_ip_address();
  * nsapi_ppp_get_gateway() called the interface's get_netmask().

First bug has always been there - second one was introduced in 5.9.

AT_CellularNetwork currently lacks calls to get both netmask and gateway
- this patch would be needed for that when added.

@kjbracey-arm kjbracey-arm dismissed stale reviews from 0xc0170 and TeemuKultala via 45e24d4 Jun 7, 2018

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:ppp-gateway branch from 403e572 to 45e24d4 Jun 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 8, 2018

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 8, 2018

Build will be resumed, once rc3 completes

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 9, 2018

Build : SUCCESS

Build number : 2300
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7161/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Jun 11, 2018

CI passed - just need reviews reapplied following edit.

@cmonr cmonr merged commit ed9a1f1 into ARMmbed:master Jun 12, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9969 cycles (+394 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:ppp-gateway branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment