-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct PPPCellularInterface::get_gateway() #7161
Conversation
Two cascading copy-paste errors stopped this working: * PPPCellularInterface::get_gateway() called nsapi_ppp_get_ip_address(); * nsapi_ppp_get_gateway() called the interface's get_netmask(). First bug has always been there - second one was introduced in 5.9. AT_CellularNetwork currently lacks calls to get both netmask and gateway - this patch would be needed for that when added.
/morph build |
Build will be resumed, once rc3 completes |
Build : FAILUREBuild number : 2284 |
/morph build |
Build : SUCCESSBuild number : 2300 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1922 |
Test : SUCCESSBuild number : 2076 |
CI passed - just need reviews reapplied following edit. |
Description
Two cascading copy-paste errors stopped this working:
First bug has always been there - second one was introduced in 5.9.
AT_CellularNetwork currently lacks calls to get both netmask and gateway - this patch would be needed for that when added.
Pull request type