-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: Add AT+CCID and AT+CGSN #7217
Conversation
@mirelachirica @jarvte please review |
@@ -21,7 +21,8 @@ | |||
#include <stddef.h> | |||
#include "nsapi_types.h" | |||
|
|||
namespace mbed { | |||
namespace mbed | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it was - it was good ( see astyle in the travis ). It shows more style issues
Style changes, own commit please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This follows Mbed OS coding guidelines, see astyle in https://os.mbed.com/teams/SDK-Development/wiki/mbed-sdk-coding-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the old one. Please do not use it. Anyway, from there "Braces - K&R (see the exception 1 TBS below)" . this {
should be attached.
Use https://os.mbed.com/docs/latest/reference/style.html (points to astylerc file that is in our codebase) . Travis runs this and can show you how this breaks the style defined there.
Taken from Travis:
-namespace mbed
-{
+namespace mbed {
/**
* Class CellularInformation
*
* An abstract interface that provides information about cellular device.
*/
-class CellularInformation
-{
+class CellularInformation {
@@ -18,12 +18,16 @@ | |||
#ifndef CELLULAR_SIM_H_ | |||
#define CELLULAR_SIM_H_ | |||
|
|||
#include <stddef.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this relates to the new API addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's for size_t definition.
7739d8d
to
44365bc
Compare
* @param buf_size max length of manufacturer identification is 2048 characters | ||
* @return on success read character count, on failure negative error code | ||
* @return zero on success, on failure negative error code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal ticket IOTCELL-1097 to unify comments about return values on APIs returning nsapi_error_t.
Suggest: "NSAPI_ERROR_OK on success, or following error codes: -list of possible error codes-"
This is working with UBLOX_C027, but I noticed that other cellular targets need more work. |
@mirelachirica @jarvte please re-review target specific adaptation |
@0xc0170 this should be now good for merge, I think. |
/morph build |
Build : SUCCESSBuild number : 2368 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2001 |
Test : SUCCESSBuild number : 2157 |
/morph uvisor-test |
@AnttiKauppila @jarvte Can you rereview please? |
Description
Added new methods in cellular API:
Fixes Arm internal ref IOTCELL-1091.
Doxygen and return types of the CellularInformation class were fixed at the same.
Usage example:
Pull request type