New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add cellular network tests #7269

Merged
merged 3 commits into from Jun 25, 2018

Conversation

Projects
None yet
6 participants
@jarvte
Contributor

jarvte commented Jun 20, 2018

Description

  • added more cellular network unit tests
  • added cellular greentea tests
  • fixed error in unit tests in master
  • fixed CellularPower:: set_power_level(int func_level, int do_reset = 0) do_reset to '0' instead of '1' so it will not break the API.
  • minor fixes to AT_CellularNetwork class which were found while doing tests

@mirelachirica @AnttiKauppila please review

Internal ref to defect: IOTCELL-917-947

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 20, 2018

continuous-integration/travis-ci/pr failure not related to this pr

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jun 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 20, 2018

continuous-integration/travis-ci/pr failure not related to this pr

Restarted. Having some travis failures recently, we reported it to Travis, waiting for their feedback

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 25, 2018

@0xc0170 Please launch morph

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 25, 2018

@@ -92,7 +92,7 @@ class CellularPower
*
* @return zero on success
*/
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1) = 0;
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 0) = 0;

This comment has been minimized.

@0xc0170

0xc0170 Jun 25, 2018

Member

what is this fixing - changing the default value?

This comment has been minimized.

@jarvte

jarvte Jun 25, 2018

Contributor

So that it's not an API change we used default value but it was wrong in this pr: #7146
Here it's corrected and now it does not change the API behaviour.

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 25, 2018

Build : SUCCESS

Build number : 2441
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7269/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 25, 2018

@cmonr cmonr merged commit 335fd58 into ARMmbed:master Jun 25, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9697 cycles (+97 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jarvte jarvte deleted the jarvte:add_cellular_network_tests branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment