Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add cellular network tests #7269

Merged
merged 3 commits into from
Jun 25, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 20, 2018

Description

  • added more cellular network unit tests
  • added cellular greentea tests
  • fixed error in unit tests in master
  • fixed CellularPower:: set_power_level(int func_level, int do_reset = 0) do_reset to '0' instead of '1' so it will not break the API.
  • minor fixes to AT_CellularNetwork class which were found while doing tests

@mirelachirica @AnttiKauppila please review

Internal ref to defect: IOTCELL-917-947

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@jarvte
Copy link
Contributor Author

jarvte commented Jun 20, 2018

continuous-integration/travis-ci/pr failure not related to this pr

@0xc0170 0xc0170 requested a review from a team June 20, 2018 08:09
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 20, 2018

continuous-integration/travis-ci/pr failure not related to this pr

Restarted. Having some travis failures recently, we reported it to Travis, waiting for their feedback

@jarvte
Copy link
Contributor Author

jarvte commented Jun 25, 2018

@0xc0170 Please launch morph

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 25, 2018

/morph build

@@ -92,7 +92,7 @@ class CellularPower
*
* @return zero on success
*/
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1) = 0;
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 0) = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this fixing - changing the default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it's not an API change we used default value but it was wrong in this pr: #7146
Here it's corrected and now it does not change the API behaviour.

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2018

Build : SUCCESS

Build number : 2441
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7269/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2018

@cmonr cmonr merged commit 335fd58 into ARMmbed:master Jun 25, 2018
@jarvte jarvte deleted the add_cellular_network_tests branch June 26, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants