-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: add cellular network tests #7269
Conversation
continuous-integration/travis-ci/pr failure not related to this pr |
Restarted. Having some travis failures recently, we reported it to Travis, waiting for their feedback |
@0xc0170 Please launch morph |
/morph build |
@@ -92,7 +92,7 @@ class CellularPower | |||
* | |||
* @return zero on success | |||
*/ | |||
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1) = 0; | |||
virtual nsapi_error_t set_power_level(int func_level, int do_reset = 0) = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this fixing - changing the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that it's not an API change we used default value but it was wrong in this pr: #7146
Here it's corrected and now it does not change the API behaviour.
Build : SUCCESSBuild number : 2441 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2072 |
Test : SUCCESSBuild number : 2220 |
Description
@mirelachirica @AnttiKauppila please review
Internal ref to defect: IOTCELL-917-947
Pull request type