Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nsdynmemlib in frameworks/nanostack-libservice #7389

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Update nsdynmemlib in frameworks/nanostack-libservice #7389

merged 2 commits into from
Jul 2, 2018

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Jul 2, 2018 •
edited
Loading

Description

Update nsdynmenlib in frameworks/libservice to match tip of https://github.com/ARMmbed/nanostack-libservice.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

This PR contains fix for #5961 and improvements:
PelionIoT/nanostack-libservice#70
PelionIoT/nanostack-libservice@2705b9b
PelionIoT/nanostack-libservice@9808289

Arto Kinnunen added 2 commits July 2, 2018 13:15
Squashed 'features/frameworks/nanostack-libservice/' changes from ddd…
a184ff5 
…45db..2705b9b

2705b9b Add IPv4 string conversion utils
8978dac Add API to set temporary allocation heap limit (ARMmbed#70)
86fa01c Update max heap size to use size_t (ARMmbed#68)
9808289 nsdynmemlib: silence IAR warnings caused by gotos skipping variable init

git-subtree-dir: features/frameworks/nanostack-libservice
git-subtree-split: 2705b9b93877f18828106df80af5b8c1c441e713
Merge commit 'a184ff592b547f153aa14c99329f65fd18515b0d'
3d5010d 
* commit 'a184ff592b547f153aa14c99329f65fd18515b0d':
  Squashed 'features/frameworks/nanostack-libservice/' changes from ddd45db..2705b9b
kjbracey
kjbracey approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but I think overall this is "feature" rather than fix. Particularly with the typedef change.

Should be targeted for 5.10 regardless, as the subtree merge doesn't play well with patching.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2493
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7389/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Test : SUCCESS

Build number : 2269
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7389/2269

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Exporter Build : SUCCESS

Build number : 2137
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7389/

@0xc0170 0xc0170 merged commit 226e799 into ARMmbed:master Jul 2, 2018
@artokin artokin deleted the update_libservice branch July 3, 2018 07:00
@artokin artokin mentioned this pull request Jul 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artokin @0xc0170 @mbed-ci @kjbracey