Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: Impl Makefile-based response/command files #7583

Closed
wants to merge 3 commits into from

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jul 23, 2018

Description

This PR updates all of the Makefile-based exporers to inculde a
response file for the link step. This should circumvent some windows
path length related issues.

Fix affects the following exporters:

  • make_gcc_arm
  • make_armc5
  • make_armc6
  • make_iar
  • eclipse_gcc_arm
  • eclipse_armc5
  • eclipse_iar

Fixes #6335

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Jul 24, 2018

Going to test locally, but will start CI in the meanwhile.

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Build : SUCCESS

Build number : 2666
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7583/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2018

One node went offline during the exporting

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2018

Anyone tested this locally with the builds that previously failed?

Going to test locally, but will start CI in the meanwhile.

@cmonr

@cmonr
Copy link
Contributor

cmonr commented Jul 25, 2018

Looks like I'm unable to verify.

Unable to run mbed export -i make_armc5 -m K64F --clean && make since #7183 came in. Will be making a seperate issue.

@theotherjimmy
Copy link
Contributor Author

Well, dang. It's really hard to find make > 3.81 for windows. I'm going to have to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants