Remove uVisor from mbed-os #7592

orenc17 · 2018-07-25T12:23:32Z

Remove uVisor from mbed-os

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[X] Breaking change

0xc0170

One question about the test, if its fine for removal

0xc0170 · 2018-07-31T08:25:43Z

tools/test/config/feature_recursive_add/FEATURE_STORAGE/lib2/mbed_lib.json

@@ -1,8 +1,3 @@
 {
-    "name": "lib2",


Removing tools/test/config/feature_recursive_add test as it uses uvisor feature, wont need any replacement?

bulislaw

Yes, lets do that! (Someone else needs to review the details)

0xc0170 · 2018-08-02T13:41:24Z

/morph build

mbed-ci · 2018-08-02T14:47:11Z

Build : FAILURE

Build number : 2727
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7592/

orenc17 · 2018-08-02T17:56:21Z

@0xc0170 @cmonr
please build again, i've fixed the IAR bug

cmonr · 2018-08-02T19:42:08Z

@orenc17 Thanks for the quick fix, but please also fix the intentation in that particular function.

On a quick glance, it was not obvious why that was a fix.

0xc0170 · 2018-08-03T08:26:02Z

rtos/TARGET_CORTEX/mbed_boot.c

@@ -712,7 +712,6 @@ void __iar_program_start( void )
    low_level_init_needed_local = __low_level_init();
    if (low_level_init_needed_local) {
        __iar_data_init3();
-    }


What is an error that this is actually fixing? I don't think this is related to uvisor anyhow.

By removing }, the lines 717 and 718 becomes unaligned.

NirSonnenschein · 2018-08-05T08:20:19Z

/morph build

mbed-ci · 2018-08-05T09:13:23Z

Build : SUCCESS

Build number : 2734
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7592/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-05T10:52:57Z

Test : SUCCESS

Build number : 2461
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7592/2461

mbed-ci · 2018-08-05T10:57:56Z

Exporter Build : SUCCESS

Build number : 2368
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7592/

0xc0170 · 2018-08-06T08:30:10Z

@orenc17 @alzix Assuming with this PR the uvisor build & test should not be part of the build command . Please advise how to proceed.

orenc17 · 2018-08-06T09:02:05Z

@studavekar FYI

studavekar · 2018-08-06T16:27:41Z

Once this PR gets in we would need to

Disable uvisor-test command form post mbed-os success ccomment
Remove AWS-CI uVisor Build & Test from mbed-os setting page

cc @ARMmbed/mbed-os-maintainers for suggestions, how do we take this PR formward.

cmonr · 2018-08-06T16:51:06Z

As much as we'd like to move this forward, removing uVisor at this point would cause one of two things to happen:

introduce a major change into 5.9, when uVisor support is marked as deprecated
-OR-
cause PRs to come into master that might not be supported in the patch release because the uVisor test still runs in 5.9 CI.

The safest time to pull this in will probably be immediately after the last patch release is merged, at which point we won't have to worry about the 5.9 branch's CI.

cmonr · 2018-08-06T16:55:29Z

I think the solution for now is to park this PR until the second to last patch release is made.

mikisch81 · 2018-08-17T19:56:40Z

Is 5.9.5 the last patch release of 5.9?
If so than I think now is the time (before all code freeze).

cmonr · 2018-08-17T20:53:10Z

@mikisch81 Sorry, it's not. 5.9.6 will be happening next week, then 5.9.7 code freeze (the last patch) will be on Sept 6th.

@ARMmbed/mbed-os-maintainers

bulislaw · 2018-08-22T10:31:15Z

Can we get that in for 5.10?

alzix · 2018-08-22T11:05:03Z

This was the plan every one agreed on.

orenc17 · 2018-08-22T13:38:30Z

Rebased on top of master and remover #7830

cmonr · 2018-08-24T04:20:33Z

Alright, so here's the plan. This is ready to go (aside from another run of CI since rebasing updates commit hashes),

We need this to come in as a part of 5.10, but not come into the 5.9.x branch. We should be able to do that by simply leaving the 5.10 label, and getting this merged before then.

Once this comes in, we'll remove the "AWS-CI uVisor Build & Test" merge check from the master branch, but keep it in the 5.9 branch.

For 5.9.7, if we encounter any patches that for some reason don't manage to pass "AWS-CI uVisor Build & Test" once the release PR is being made, we'll remove it from the patch and only bring it in for 5.10.

After 5.9.7 has been released, the Jenkins job(s) behind "AWS-CI uVisor Build & Test" can be removed.

@orenc17 @alzix @ARMmbed/mbed-os-maintainers Sound like a plan?

alzix · 2018-08-24T10:18:35Z

Finally someone with a plan. LGTM.

0xc0170 · 2018-08-24T13:22:34Z

/morph build

mbed-ci · 2018-08-24T17:44:41Z

Build : SUCCESS

Build number : 2898
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7592/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-24T20:06:58Z

Exporter Build : FAILURE

Build number : 2523
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7592/

cmonr · 2018-08-24T22:53:46Z

Ooph. License checkout issues.

/morph export-build

mbed-ci · 2018-08-25T01:04:36Z

Exporter Build : SUCCESS

Build number : 2526
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7592/

cmonr · 2018-08-25T01:11:37Z

/morph uvisor-test

alzix · 2018-08-25T05:56:51Z

What do we expect uvisor-test check to do when this PR removed uVisor?
Instead we need to tweak GitHub branch protection to remove uVisor tests as a mandatory precondition.

mbed-ci · 2018-08-25T10:25:01Z

Test : SUCCESS

Build number : 2649
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7592/2649

cmonr · 2018-08-25T13:19:03Z

@alzix My mistake, was on autopilot.

cmonr · 2018-08-26T00:52:19Z

Bringing this in. I disabled the test in GitHub for the master branch, but I guess the check isn't going away since it was run for this PR.

@ARMmbed/mbed-os-maintainers Make note that uVisor will not be tested on master, and if a PR fails for 5.9.7, it will be taken out of the patch.

0xc0170 added the needs: review label Jul 25, 2018

0xc0170 requested review from bulislaw and alzix July 25, 2018 13:03

orenc17 force-pushed the remove_uvisor branch from 7d34deb to 0f17472 Compare July 26, 2018 11:49

alzix mentioned this pull request Jul 31, 2018

Removing unused rt_OsEventObserver #7635

Closed

alzix approved these changes Jul 31, 2018

View reviewed changes

0xc0170 approved these changes Jul 31, 2018

View reviewed changes

bulislaw approved these changes Aug 2, 2018

View reviewed changes

cmonr added needs: work release-version: 5.10.0-rc1 and removed needs: review labels Aug 2, 2018

0xc0170 reviewed Aug 3, 2018

View reviewed changes

orenc17 force-pushed the remove_uvisor branch 3 times, most recently from 2556c64 to feb9362 Compare August 4, 2018 20:00

NirSonnenschein added needs: CI and removed needs: work labels Aug 5, 2018

alzix mentioned this pull request Aug 16, 2018

Remove uVisor ARMmbed/mbed-os-5-docs#668

Merged

Remove uVisor from mbed-os

787317b

orenc17 force-pushed the remove_uvisor branch from feb9362 to 787317b Compare August 22, 2018 13:37

cmonr added the risk: G label Aug 23, 2018

cmonr added needs: CI and removed do not merge labels Aug 24, 2018

deepikabhavnani mentioned this pull request Aug 24, 2018

Update CMSIS to 5.4.0 #7875

Merged

cmonr merged commit 2f8e679 into ARMmbed:master Aug 26, 2018

0xc0170 removed the needs: CI label Aug 26, 2018

cmonr removed the risk: G label Aug 26, 2018

bridadan mentioned this pull request Nov 8, 2018

Clean up deprecated feature code #8685

Merged

orenc17 mentioned this pull request Dec 7, 2018

Removing feature names from the "allowed feature" config list. #7799

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove uVisor from mbed-os #7592

Remove uVisor from mbed-os #7592

orenc17 commented Jul 25, 2018

0xc0170 left a comment

0xc0170 Jul 31, 2018

bulislaw left a comment

0xc0170 commented Aug 2, 2018

mbed-ci commented Aug 2, 2018

orenc17 commented Aug 2, 2018

cmonr commented Aug 2, 2018

0xc0170 Aug 3, 2018

NirSonnenschein commented Aug 5, 2018

mbed-ci commented Aug 5, 2018

mbed-ci commented Aug 5, 2018

mbed-ci commented Aug 5, 2018

0xc0170 commented Aug 6, 2018

orenc17 commented Aug 6, 2018

studavekar commented Aug 6, 2018

cmonr commented Aug 6, 2018

cmonr commented Aug 6, 2018

mikisch81 commented Aug 17, 2018

cmonr commented Aug 17, 2018

bulislaw commented Aug 22, 2018

alzix commented Aug 22, 2018

orenc17 commented Aug 22, 2018

cmonr commented Aug 24, 2018

alzix commented Aug 24, 2018

0xc0170 commented Aug 24, 2018

mbed-ci commented Aug 24, 2018

mbed-ci commented Aug 24, 2018

cmonr commented Aug 24, 2018

mbed-ci commented Aug 25, 2018

cmonr commented Aug 25, 2018

alzix commented Aug 25, 2018

mbed-ci commented Aug 25, 2018

cmonr commented Aug 25, 2018

cmonr commented Aug 26, 2018

Remove uVisor from mbed-os #7592

Remove uVisor from mbed-os #7592

Conversation

orenc17 commented Jul 25, 2018