Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the configuration for RTX evr events #7628

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Optimize the configuration for RTX evr events #7628

merged 1 commit into from
Jul 31, 2018

Conversation

SenRamakri
Copy link
Contributor

Description

Optimize the configuration for RTX evr events to disable the events not used in Mbed-OS. This saves around 850 bytes of ROM.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

deepikabhavnani
deepikabhavnani reviewed Jul 27, 2018
View reviewed changes
rtos/TARGET_CORTEX/mbed_rtx_conf.h Outdated
#define EVR_RTX_MEMORY_BLOCK_INIT_DISABLE
#define EVR_RTX_MEMORY_BLOCK_ALLOC_DISABLE
#define EVR_RTX_MEMORY_BLOCK_FREE_DISABLE
//#define EVR_RTX_KERNEL_ERROR_DISABLE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Please remove all commented defines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally left them there as commented to indicate that we use them. Should we add a comment that these are used.

@cmonr
Copy link
Contributor

cmonr commented Jul 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2695
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7628/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Exporter Build : SUCCESS

Build number : 2325
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7628/

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Test : SUCCESS

Build number : 2426
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7628/2426

@0xc0170 0xc0170 changed the title Optimize the configuration for RTX evr events to disable the ones not… Optimize the configuration for RTX evr events Jul 31, 2018
@cmonr cmonr merged commit 41bd4c4 into ARMmbed:master Jul 31, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7628 from SenRamakri/sen_RtxEvrOptimization
61754b7 
Optimize the configuration for RTX evr events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SenRamakri @cmonr @mbed-ci @0xc0170 @deepikabhavnani