New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the configuration for RTX evr events #7628

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
5 participants
@SenRamakri
Contributor

SenRamakri commented Jul 27, 2018

Description

Optimize the configuration for RTX evr events to disable the events not used in Mbed-OS. This saves around 850 bytes of ROM.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SenRamakri SenRamakri requested a review from deepikabhavnani Jul 27, 2018

#define EVR_RTX_MEMORY_BLOCK_INIT_DISABLE
#define EVR_RTX_MEMORY_BLOCK_ALLOC_DISABLE
#define EVR_RTX_MEMORY_BLOCK_FREE_DISABLE
//#define EVR_RTX_KERNEL_ERROR_DISABLE

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Jul 27, 2018

Contributor

Change looks good. Please remove all commented defines

This comment has been minimized.

@SenRamakri

SenRamakri Jul 27, 2018

Contributor

I intentionally left them there as commented to indicate that we use them. Should we add a comment that these are used.

@SenRamakri SenRamakri force-pushed the SenRamakri:sen_RtxEvrOptimization branch from fe8ccea to 6221e6f Jul 27, 2018

@0xc0170 0xc0170 added the needs: CI label Jul 30, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2695
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7628/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 31, 2018

@0xc0170 0xc0170 changed the title from Optimize the configuration for RTX evr events to disable the ones not… to Optimize the configuration for RTX evr events Jul 31, 2018

@cmonr cmonr merged commit 41bd4c4 into ARMmbed:master Jul 31, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8924 cycles (-746 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7628 from SenRamakri/sen_RtxEvrOptimization
Optimize the configuration for RTX evr events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment