Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When stack stats enabled, prevent exceptions if memory allocations fail #7730

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

davidsaada
Copy link
Contributor

@davidsaada davidsaada commented Aug 8, 2018

Description

Stack stats allocate memory for sending stat reports, usually based on number of threads. this may generate exceptions if not enough memory is available for this. Make sure this is handled properly.
Resolves #7712.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@davidsaada
Copy link
Contributor Author

Please do not merge. Seems like I only solved part of the cases, but not all.

@davidsaada
Copy link
Contributor Author

@cmonr @0xc0170 OK to merge. PR is good. The problem I found was in a specific test, which should be handled separately.

@cmonr cmonr removed the do not merge label Aug 9, 2018
@adbridge
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2806
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7730/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

Holding for answer to question(s) about the new test-skipping behavior asked here: #7744 (review)

@davidsaada
Copy link
Contributor Author

Holding for answer to question(s) about the new test-skipping behavior asked here: #7744 (review)

@cmonr I think we can move on, following our agreements in that PR.

@0xc0170 0xc0170 merged commit 871d7e7 into ARMmbed:master Aug 24, 2018
@davidsaada davidsaada deleted the david_stack_stats_fail_fix branch December 12, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants