New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When stack stats enabled, prevent exceptions if memory allocations fail #7730

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
6 participants
@davidsaada
Contributor

davidsaada commented Aug 8, 2018

Description

Stack stats allocate memory for sending stat reports, usually based on number of threads. this may generate exceptions if not enough memory is available for this. Make sure this is handled properly.
Resolves #7712.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested review from ARMmbed/mbed-os-test and bulislaw Aug 8, 2018

@cmonr cmonr added the needs: review label Aug 8, 2018

@deepikabhavnani

Thanks for the fix 👍

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Aug 8, 2018

Please do not merge. Seems like I only solved part of the cases, but not all.

@cmonr cmonr added the do not merge label Aug 8, 2018

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Aug 9, 2018

@cmonr @0xc0170 OK to merge. PR is good. The problem I found was in a specific test, which should be handled separately.

@cmonr cmonr removed the do not merge label Aug 9, 2018

@0xc0170

0xc0170 approved these changes Aug 9, 2018

@adbridge adbridge added needs: CI and removed needs: review labels Aug 14, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2806
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7730/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

Holding for answer to question(s) about the new test-skipping behavior asked here: #7744 (review)

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Aug 22, 2018

Holding for answer to question(s) about the new test-skipping behavior asked here: #7744 (review)

@cmonr I think we can move on, following our agreements in that PR.

@0xc0170 0xc0170 merged commit 871d7e7 into ARMmbed:master Aug 24, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10868 cycles (+1604 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 29, 2018

Merge pull request ARMmbed#7730 from davidsaada/david_stack_stats_fai…
…l_fix

When stack stats enabled, prevent exceptions if memory allocations fail

@davidsaada davidsaada deleted the davidsaada:david_stack_stats_fail_fix branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment