New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Handle AT response stop in case IP address is missing from … #7740

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
7 participants
@mirelachirica
Contributor

mirelachirica commented Aug 9, 2018

…CGPADDR response

Description

Failing to handle the AT+CGPADDR response to the end, in case IP address, which is an optional parameter, is missing. This is causing issues for AT commands coming after(noticed with socket creation AT+NSOCR for wise_1570).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 9, 2018

@cmonr cmonr added the needs: review label Aug 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

@ARMmbed/mbed-os-wan Mind reviewing this tiny PR?

@cmonr

cmonr approved these changes Aug 14, 2018

LGTM

@jarvte

jarvte approved these changes Aug 14, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 14, 2018

/morph build

@adbridge adbridge added needs: CI and removed needs: review labels Aug 14, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

Going to retry the build. Something odd seems to have happened.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2815
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7740/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 7b8a137 into ARMmbed:master Aug 16, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9067 cycles (-749 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7740 from mirelachirica/missing_resp_stop
Cellular: Handle AT response stop in case IP address is missing from …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment