Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Handle AT response stop in case IP address is missing from … #7740

Merged
merged 1 commit into from Aug 16, 2018

Conversation

mirelachirica
Copy link
Contributor

…CGPADDR response

Description

Failing to handle the AT+CGPADDR response to the end, in case IP address, which is an optional parameter, is missing. This is causing issues for AT commands coming after(noticed with socket creation AT+NSOCR for wise_1570).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 9, 2018 12:00
@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

@ARMmbed/mbed-os-wan Mind reviewing this tiny PR?

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : FAILURE

Build number : 2807
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7740/

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

Going to retry the build. Something odd seems to have happened.

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2815
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7740/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2018

@cmonr cmonr merged commit 7b8a137 into ARMmbed:master Aug 16, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Cellular: Handle AT response stop in case IP address is missing from …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants