Build tool fixes for Musca support #7792

deepikabhavnani · 2018-08-14T16:53:31Z

Description

Typos and minor fixes required to support Cortex-M33 devices. Support of M33 was not tested since we didn;t had any target. This PR will be tested internally with MUSCA.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

cmonr

LGTM, just some questions

cmonr · 2018-08-15T03:14:33Z

tools/toolchains/arm.py

-            self.flags['common'].append("-mcpu=%s" % target.core.lower())
-            self.flags['ld'].append("--cpu=%s" % target.core.lower())
-            self.SHEBANG += " -mcpu=%s" % target.core.lower()
+            if not target.core.startswith("Cortex-M23") and not target.core.startswith("Cortex-M33"):


Hmm, so I take it building for the NS side no longer needs to be differentiated?

Differentiation is still there, here we are just not setting ‘-mcpu’ parameter for any of v8M device. If we set cpu as cortex-m33 in flags, compiler enables dsp as well which is optional. Hence we just set ‘-march’

Please collapse the

else: if: ...

into

elif:

cmonr · 2018-08-15T03:16:27Z

tools/toolchains/gcc.py

@@ -256,8 +256,6 @@ def link(self, output, objects, libraries, lib_dirs, mem_map):
        # Exec command
        self.notify.cc_verbose("Link: %s" % ' '.join(cmd))
        self.default_cmd(cmd)
-        if self.target.core == "Cortex-M23" or self.target.core == "Cortex-M33":


Why is this output no longer needed? (Commit only mentioned something about a build issue)

Code for creation of ‘secure_file’ was initially in this section and later moved to other part. Variable ‘secure_file’ is not available here and hence throws error

-mcpu option if set for v8M CPU;s it will add DSP feature as default which is optional. Hence setting just the architecture for Cortex-M23 and Cortex-M33

As per the link below, options for clang and armlink are diferrent for Cortex-M33 armlink --cpu 8-M.Main --import-cmse-lib-out importlib_v1.o armclang -march=armv8-m.main -mcmse http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0773h/pge1452794854109.html

deepikabhavnani · 2018-08-16T20:54:37Z

Fix in 6366452 : Options for clang and armlink are diferrent for Cortex-M33

armlink --cpu 8-M.Main --import-cmse-lib-out importlib_v1.o
armclang -march=armv8-m.main -mcmse

http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0773h/pge1452794854109.html

cc @gaborkertesz

deepikabhavnani · 2018-08-16T22:52:40Z

@theotherjimmy - We have few issues while building ASM files. All the C flags are added to asm build, as a result .o generated is not correct.

Compile: C:\Program Files\ARMCompiler6.10\bin\armasm --cpu=8-M.Main --cpreproc --**cpreproc_opts=-c**,--target=arm-arm-none-eabi,-mthumb,-Os,-Wno-armcc-pragma-push-pop,-Wno-armcc-pragma-anon-unions,-DMULADDC_CANNOT_USE_R7,-fdata-sections,-fno-exceptions,-MMD,-D_LIBCPP_EXTERN_TEMPLATE(...)=,-D__STARTUP_COPY_MULTIPLE,-D__CORTEX_M33,-DMBED_FAULT_HANDLER_DISABLED,-D__MBED_CMSIS_RTOS_CM,-D__STARTUP_CLEAR_BSS,-D__CMSIS_RTOS,-DARM_MATH_ARMV8MML,-I.,-I.\mbed-os,-I.\mbed-os\cmsis,-I.\mbed-os\cmsis\TARGET_CORTEX_M,-I.\mbed-os\drivers,-I.\mbed-os\events,-I.\mbed-os\events\equeue,-I.\mbed-os\features,-I.\mbed-os\features\cellular,-I.\mbed-os\features\cellular\easy_cellular,

[DEBUG] Output: armclang.exe: warning: .\mbed-os\targets\TARGET_ARM_SSG\TARGET_MUSCA_A1\TOOLCHAIN_ARMC6\startup_cmsdk_musca.s: 'assembler' input unused [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-mthumb' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-Wno-armcc-pragma-push-pop' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-Wno-armcc-pragma-anon-unions' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-D MULADDC_CANNOT_USE_R7' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-fdata-sections' [-Wunused-command-line-argument]
[DEBUG] Output: armclang.exe: warning: argument unused during compilation: '-fno-exceptions' [-Wunused-command-line-argument]

Resolved below warnings Warning: L3912W: Option 'legacyalign' is deprecated. Warning: L3912W: Option 'no_strict_wchar_size' is deprecated. Warning: L3912W: Option 'no_strict_enum_size' is deprecated.

deepikabhavnani · 2018-08-17T16:35:06Z

We have few issues while building ASM files. All the C flags are added to asm build, as a result .o generated is not correct.

Issue relate to ASM file build was related to assembly file extension ".s", and is resolved by updating it to be caps .S

deepikabhavnani · 2018-08-17T16:35:40Z

@theotherjimmy @gaborkertesz - Please review

gaborkertesz · 2018-08-22T20:29:44Z

Basic hello world example has been tested with armclang and gcc on Musca and working as expected as a secure only application.

deepikabhavnani · 2018-08-22T20:35:46Z

@theotherjimmy @cmonr - Please review

theotherjimmy · 2018-08-23T13:24:42Z

tools/toolchains/arm.py

+            self.flags['c'].append("-mcpu=cortex-m33+nodsp")
+            self.flags['c'].append("-mfpu=none")
+            self.flags['cxx'].append("-mcpu=cortex-m33+nodsp")
+            self.flags['cxx'].append("-mfpu=none")


Can these be added to common?

theotherjimmy · 2018-08-23T13:24:53Z

tools/toolchains/arm.py


        if target.core == "Cortex-M23" or target.core == "Cortex-M33":
-            self.flags['common'].append("-mcmse")
+            self.flags['cxx'].append("-mcmse")
+            self.flags['c'].append("-mcmse")


Could this be added to common?

This flag gives warning with linker and armasm.

0xc0170 · 2018-08-23T13:27:02Z

I got one question - removing those legacy flags from linker command - the warning is for ARMC6 only (can't be seen in ARMC5) ? This is safe to remove, no functionality change?

deepikabhavnani · 2018-08-23T13:47:44Z

I got one question - removing those legacy flags from linker command

Legacy linker flags are not present for ARM 5 compiler,
https://github.com/ARMmbed/mbed-os/pull/7792/files#diff-84bdeb5b184eec3910a5d6a23df9ceccL35

I don;t see those flags even in history of ARM 5 compiler, @theotherjimmy - any idea why those flags were added for ARMC6.

This is safe to remove

Should be, as they have no impact. Deprecated as per this link http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0381b/CHDHCGGF.html

@gabor

Change shared by @gabor Kertesz Hard-fault on Musca was because of enabled floating point instructions, disabling DSP and FPU.

deepikabhavnani · 2018-08-23T14:18:21Z

@theotherjimmy - I also see below warning in detail build dumps, not sure what is causing this.

[DEBUG] Errors: warning: 'armv4t' is unsupported in this version of the product

Changes done

deepikabhavnani · 2018-08-27T15:01:21Z

Can we start the build for this PR?

cmonr · 2018-08-27T15:05:17Z

Does #7792 (comment) not need to be addressed?

deepikabhavnani · 2018-08-27T15:11:21Z

Does #7792 (comment) not need to be addressed?

Its warning, can be fixed later as well. Musca is dependent on this fix for now. Added issue to handle it later #7900

cmonr · 2018-08-27T15:18:19Z

/morph build

mbed-ci · 2018-08-27T21:42:54Z

Build : SUCCESS

Build number : 2933
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7792/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-27T23:33:22Z

Exporter Build : SUCCESS

Build number : 2551
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7792/

mbed-ci · 2018-08-28T14:56:46Z

Test : SUCCESS

Build number : 2682
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7792/2682

Fix build and typo issues with M33 build

08b4e34

deepikabhavnani requested a review from theotherjimmy August 14, 2018 16:53

cmonr reviewed Aug 15, 2018

View reviewed changes

cmonr added the needs: review label Aug 15, 2018

-mcpu option not needed for v8M devices

beab422

-mcpu option if set for v8M CPU;s it will add DSP feature as default which is optional. Hence setting just the architecture for Cortex-M23 and Cortex-M33

deepikabhavnani force-pushed the fix_m33 branch from a84ebee to beab422 Compare August 15, 2018 18:52

Remove deprecated linker options

37a5646

Resolved below warnings Warning: L3912W: Option 'legacyalign' is deprecated. Warning: L3912W: Option 'no_strict_wchar_size' is deprecated. Warning: L3912W: Option 'no_strict_enum_size' is deprecated.

deepikabhavnani requested a review from gaborkertesz August 20, 2018 22:03

deepikabhavnani force-pushed the fix_m33 branch from e9d53ab to 3fcf14e Compare August 22, 2018 18:28

gaborkertesz approved these changes Aug 22, 2018

View reviewed changes

0xc0170 added the release-version: 5.10.0-rc1 label Aug 23, 2018

theotherjimmy previously requested changes Aug 23, 2018

View reviewed changes

Disabling DSP and FPU for Cortex-M33

ed58ff0

Change shared by @gabor Kertesz Hard-fault on Musca was because of enabled floating point instructions, disabling DSP and FPU.

deepikabhavnani force-pushed the fix_m33 branch from 3fcf14e to ed58ff0 Compare August 23, 2018 14:07

cmonr added the risk: G label Aug 24, 2018

deepikabhavnani mentioned this pull request Aug 27, 2018

'armv4t' warning when compiling with ARMC6 #7900

Closed

cmonr added needs: CI and removed needs: review labels Aug 27, 2018

cmonr approved these changes Aug 28, 2018

View reviewed changes

cmonr merged commit 14319ad into ARMmbed:master Aug 28, 2018

0xc0170 removed the needs: CI label Aug 28, 2018

cmonr removed the risk: G label Sep 2, 2018

0xc0170 mentioned this pull request Sep 5, 2018

ARMC6: legacy align error #8004

Closed

deepikabhavnani deleted the fix_m33 branch September 28, 2018 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build tool fixes for Musca support #7792

Build tool fixes for Musca support #7792

deepikabhavnani commented Aug 14, 2018

cmonr left a comment

cmonr Aug 15, 2018

deepikabhavnani Aug 15, 2018

theotherjimmy Aug 15, 2018

cmonr Aug 15, 2018

deepikabhavnani Aug 15, 2018

deepikabhavnani commented Aug 16, 2018 •

edited

Loading

deepikabhavnani commented Aug 16, 2018

deepikabhavnani commented Aug 17, 2018

deepikabhavnani commented Aug 17, 2018

gaborkertesz commented Aug 22, 2018

deepikabhavnani commented Aug 22, 2018

theotherjimmy Aug 23, 2018

deepikabhavnani Aug 23, 2018

theotherjimmy Aug 23, 2018

deepikabhavnani Aug 23, 2018

0xc0170 commented Aug 23, 2018

deepikabhavnani commented Aug 23, 2018 •

edited

Loading

deepikabhavnani commented Aug 23, 2018

deepikabhavnani commented Aug 27, 2018

cmonr commented Aug 27, 2018

deepikabhavnani commented Aug 27, 2018 •

edited

Loading

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 28, 2018

Build tool fixes for Musca support #7792

Build tool fixes for Musca support #7792

Conversation

deepikabhavnani commented Aug 14, 2018

Description

Pull request type

cmonr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepikabhavnani commented Aug 16, 2018 • edited Loading

deepikabhavnani commented Aug 16, 2018

deepikabhavnani commented Aug 17, 2018

deepikabhavnani commented Aug 17, 2018

gaborkertesz commented Aug 22, 2018

deepikabhavnani commented Aug 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Aug 23, 2018

deepikabhavnani commented Aug 23, 2018 • edited Loading

deepikabhavnani commented Aug 23, 2018

deepikabhavnani commented Aug 27, 2018

cmonr commented Aug 27, 2018

deepikabhavnani commented Aug 27, 2018 • edited Loading

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

Triggering tests

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 28, 2018

deepikabhavnani commented Aug 16, 2018 •

edited

Loading

deepikabhavnani commented Aug 23, 2018 •

edited

Loading

deepikabhavnani commented Aug 27, 2018 •

edited

Loading