-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Modified version mismatch msg to be warning instead of error #7876
Conversation
@cmonr Can we proceed this one, there was another recent report regarding this error (it is not error but just a warning, build continues). |
@@ -121,7 +121,7 @@ def version_check(self): | |||
"file": "", | |||
"line": "", | |||
"col": "", | |||
"severity": "ERROR", | |||
"severity": "WARNING", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this WARNING
and other two just "Warning" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 Which other two are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other toolchains, but I can see this one used previously capital letters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
/morph build |
Build : SUCCESSBuild number : 3208 Triggering tests/morph test |
Test : FAILUREBuild number : 3008 |
/morph test |
Test : SUCCESSBuild number : 3009 |
The test all passes but we investigating the failure in the logs (not affecting the test executed, reported #8294). |
Exporter Build : FAILUREBuild number : 2799 |
We are checking the exporters failures (not related to the PR most likely) |
/morph export-build |
Exporter Build : FAILUREBuild number : 2807 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2808 |
Description
It was mientioned, but slipped in the original PR that the version mismatch message be a warning instead of an error. The current mesasge is prefixed with
[Error]
which appears to be confusing users since the build continues (sometimes just fine).This PR changes
[Error]
to[Warning]
Pull request type