Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Modified version mismatch msg to be warning instead of error #7876

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Aug 24, 2018

Description

It was mientioned, but slipped in the original PR that the version mismatch message be a warning instead of an error. The current mesasge is prefixed with [Error] which appears to be confusing users since the build continues (sometimes just fine).

This PR changes [Error] to [Warning]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

@cmonr Can we proceed this one, there was another recent report regarding this error (it is not error but just a warning, build continues).

@@ -121,7 +121,7 @@ def version_check(self):
"file": "",
"line": "",
"col": "",
"severity": "ERROR",
"severity": "WARNING",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this WARNING and other two just "Warning" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 Which other two are you referring to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other toolchains, but I can see this one used previously capital letters

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@theotherjimmy
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 1, 2018

Build : SUCCESS

Build number : 3208
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7876/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

The test all passes but we investigating the failure in the logs (not affecting the test executed, reported #8294).

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

We are checking the exporters failures (not related to the PR most likely)

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants