New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Modified version mismatch msg to be warning instead of error #7876

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
5 participants
@cmonr
Contributor

cmonr commented Aug 24, 2018

Description

It was mientioned, but slipped in the original PR that the version mismatch message be a warning instead of an error. The current mesasge is prefixed with [Error] which appears to be confusing users since the build continues (sometimes just fine).

This PR changes [Error] to [Warning]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr added the needs: review label Aug 24, 2018

@cmonr cmonr requested a review from theotherjimmy Aug 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 21, 2018

@cmonr Can we proceed this one, there was another recent report regarding this error (it is not error but just a warning, build continues).

@@ -121,7 +121,7 @@ def version_check(self):
"file": "",
"line": "",
"col": "",
"severity": "ERROR",
"severity": "WARNING",

This comment has been minimized.

@0xc0170

0xc0170 Sep 21, 2018

Member

why is this WARNING and other two just "Warning" ?

This comment has been minimized.

@cmonr

cmonr Sep 21, 2018

Contributor

@0xc0170 Which other two are you referring to?

This comment has been minimized.

@0xc0170

0xc0170 Sep 21, 2018

Member

other toolchains, but I can see this one used previously capital letters

@theotherjimmy

Looks fine to me.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 1, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 1, 2018

Build : SUCCESS

Build number : 3208
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7876/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

The test all passes but we investigating the failure in the logs (not affecting the test executed, reported #8294).

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

We are checking the exporters failures (not related to the PR most likely)

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 1af1a4a into ARMmbed:master Oct 4, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.28%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 585 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9215 cycles (-880 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment