Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: CellularDevice unittests fix initialization #7894

Merged
merged 2 commits into from
Sep 2, 2018
Merged

Cellular: CellularDevice unittests fix initialization #7894

merged 2 commits into from
Sep 2, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Aug 27, 2018

…ons between tests.

Description

Fixed CellularDevice unittests by doing proper initializations.
AT_CellularBase_stub was returning a wrong reference to ATHandler_stub.

Only unit tests changed, no code changes.

Internal ref to defect: IOTCELL-1275

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 27, 2018 11:21
@0xc0170 0xc0170 changed the title Cellular: fixed CellularDevice unittests by doing proper initializati… Cellular: CellularDevice unittests fix initialization Aug 29, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

Build : SUCCESS

Build number : 2949
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7894/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

Exporter Build : SUCCESS

Build number : 2565
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7894/

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

Test : FAILURE

Build number : 2696
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7894/2696

@jarvte
Copy link
Contributor Author

jarvte commented Aug 30, 2018

@0xc0170 failure not related to this pr.

@AnttiKauppila
Copy link

This is targeted to 5.10.0-rc2

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2018

Test : SUCCESS

Build number : 2748
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7894/2748

@0xc0170 0xc0170 merged commit e7b3c0d into ARMmbed:master Sep 2, 2018
@jarvte jarvte deleted the fix_cellular_unittests branch October 22, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jarvte @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila @NirSonnenschein