New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: CellularDevice unittests fix initialization #7894

Merged
merged 2 commits into from Sep 2, 2018

Conversation

Projects
None yet
6 participants
@jarvte
Contributor

jarvte commented Aug 27, 2018

…ons between tests.

Description

Fixed CellularDevice unittests by doing proper initializations.
AT_CellularBase_stub was returning a wrong reference to ATHandler_stub.

Only unit tests changed, no code changes.

Internal ref to defect: IOTCELL-1275

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 27, 2018

@0xc0170 0xc0170 changed the title from Cellular: fixed CellularDevice unittests by doing proper initializati… to Cellular: CellularDevice unittests fix initialization Aug 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 29, 2018

Build : SUCCESS

Build number : 2949
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7894/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Aug 30, 2018

@0xc0170 failure not related to this pr.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Sep 2, 2018

This is targeted to 5.10.0-rc2

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 2, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit e7b3c0d into ARMmbed:master Sep 2, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 555 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9900 cycles (+761 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 2, 2018

@jarvte jarvte deleted the jarvte:fix_cellular_unittests branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment