Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up include paths. #7903

Merged
merged 1 commit into from Sep 19, 2018
Merged

Clean up include paths. #7903

merged 1 commit into from Sep 19, 2018

Conversation

tkem
Copy link
Contributor

@tkem tkem commented Aug 27, 2018

Description

When studying the mbed source code, I noticed #includes usually refer to files in other directories using double-quoted paths relative to the repository root ("platform/platform.h", "hal/gpio_api.h", etc.).
There are a few files where this is not the case, apparently relying on includes path implicitly set by the build environment. So this is not a real issue (until you change the build environment, of course), but simply something I'd suggest for consistency...

Pull request type

Nothing's broken (for now), so I think "Refactor" describes this best (you may want to add "Code Cleanup" as an option some day).

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 28, 2018 06:57
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleanup. Looks good to me 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3096
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7903/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr cmonr requested a review from c1728p9 September 18, 2018 16:44
@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 19, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 3d94fb8 into ARMmbed:master Sep 19, 2018
@tkem tkem deleted the fix/cleanup-include-paths branch October 21, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants