New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up include paths. #7903

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
6 participants
@tkem
Contributor

tkem commented Aug 27, 2018

Description

When studying the mbed source code, I noticed #includes usually refer to files in other directories using double-quoted paths relative to the repository root ("platform/platform.h", "hal/gpio_api.h", etc.).
There are a few files where this is not the case, apparently relying on includes path implicitly set by the build environment. So this is not a real issue (until you change the build environment, of course), but simply something I'd suggest for consistency...

Pull request type

Nothing's broken (for now), so I think "Refactor" describes this best (you may want to add "Code Cleanup" as an option some day).

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core Aug 28, 2018

@deepikabhavnani

Thanks for cleanup. Looks good to me 👍

@cmonr cmonr added needs: CI and removed needs: review labels Aug 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3096
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7903/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr cmonr requested a review from c1728p9 Sep 18, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 19, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 3d94fb8 into ARMmbed:master Sep 19, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 555 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9971 cycles (+832 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@tkem tkem deleted the tkem:fix/cleanup-include-paths branch Oct 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment