New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix Greentea test for network attach #7910

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
6 participants
@AriParkkila
Contributor

AriParkkila commented Aug 28, 2018

Description

Added 10 seconds wait in Greentea test before trying to attach after network registration test. Cellular network attach can't be done before DUT is registered to a network.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 28, 2018

@jarvte please review

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 28, 2018

@jarvte

jarvte approved these changes Aug 29, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Sep 2, 2018

This is targeted to 5.10.0-rc2

@0xc0170

0xc0170 approved these changes Sep 3, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 3, 2018

Build : SUCCESS

Build number : 2993
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7910/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 3, 2018

/morph test

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 3, 2018

Restarted tests on this PR as the failure did not look to be related

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 4, 2018

@0xc0170 0xc0170 merged commit b20fd50 into ARMmbed:master Sep 4, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 555 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10291 cycles (+1052 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 4, 2018

@AriParkkila AriParkkila deleted the AriParkkila:cell-test-attach branch Sep 10, 2018

@AriParkkila AriParkkila restored the AriParkkila:cell-test-attach branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment