Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SYNCHRONOUS_DNS_CACHE test to extended set #7945

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Move SYNCHRONOUS_DNS_CACHE test to extended set #7945

merged 1 commit into from
Sep 14, 2018

Conversation

jarlamsa
Copy link
Contributor

@jarlamsa jarlamsa commented Aug 31, 2018 •
edited
Loading

Description

Temporarily move SYNCHRONOUS_DNS_CACHE to extended test set until we are able to solve the issues with it.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@jarlamsa
Copy link
Contributor Author

@mikaleppanen please review

0xc0170
0xc0170 reviewed Aug 31, 2018
View reviewed changes
TESTS/netsocket/dns/main.cpp
@@ -178,7 +178,9 @@ Case cases[] = {
#endif
Case("SYNCHRONOUS_DNS", SYNCHRONOUS_DNS),
Case("SYNCHRONOUS_DNS_MULTIPLE", SYNCHRONOUS_DNS_MULTIPLE),
#ifdef MBED_EXTENDED_TESTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is MBED_EXTENDED_TESTS documented? I noticed few tests have this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its documented anywhere currently. Temporarily moving the test to extended tests until we are able to solve the issues with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is documented in the test plan
https://github.com/ARMmbed/mbed-os/tree/master/TESTS/netsocket#building-test-binaries

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018 •
edited
Loading

The commit does not specify why is this being moved under MBED_EXTENDED_TESTS - time requirements, memory or something else? If there is a reason for this move

@jarlamsa
Copy link
Contributor Author

Changed description

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

Also please update the commit message (more important to have it there than in the description here). IT does not reference/state what issues are there

OPpuolitaival
OPpuolitaival approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 please merge this soon.. our new test job is failing because of this

0xc0170
0xc0170 approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there's a task for this to be reenabled again (make the test reliable in regular test group).

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Build : FAILURE

Build number : 3002
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7945/

@jarlamsa
Copy link
Contributor Author

jarlamsa commented Sep 5, 2018

Theres a ticket ready for getting it back from extended test set.
Seems like there was some Jenkins issue in the build.

@jarlamsa
Copy link
Contributor Author

@0xc0170 Could the build for this be triggered again, previous failure seems to be some jenkins-related issue?

@SeppoTakalo
Copy link
Contributor

@0xc0170
This needs builds&test and merge. The testcase is unstable so it creates uncertainty on our PR checks.

@SeppoTakalo
Copy link
Contributor

@kjbracey-arm Please start tests for this.
Also, remove the "Needs review" label. This has been reviewed.

@kjbracey
Copy link
Contributor

Does this need to get in for 5.10-rc2? CI machines having various problems, and need to prioritise rc2 PRs.

@SeppoTakalo
Copy link
Contributor

Not specifically.. anytime when there is a slot

@kjbracey
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3056
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7945/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Test : SUCCESS

Build number : 2834
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7945/2834

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Exporter Build : FAILURE

Build number : 2671
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7945/

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

Poop. ARM network license issues.

/morph build

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

sigh That was meant to be a rerun of the export job, not the entire thing. My bad.

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3062
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7945/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Exporter Build : SUCCESS

Build number : 2676
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7945/

@adbridge
Copy link
Contributor

/morph test

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 13, 2018

Test : FAILURE

Build number : 2845
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7945/2845

@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

Something is funky with the network tests after our network switch had to be restarted. Investigating and will restart.

@cmonr
Copy link
Contributor

cmonr commented Sep 14, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 14, 2018

Test : FAILURE

Build number : 2853
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7945/2853

@SeppoTakalo
Copy link
Contributor

tests-mbed_hal-us_ticker failed. Not relevant to this PR.

Please restart the test and @ARMmbed/mbed-os-hal please fix the unstable test.

@maciejbocianski
Copy link
Contributor

The error was SYNC_FAILED
It's rather problem with test infrastructure than with the test itself

@cmonr
Copy link
Contributor

cmonr commented Sep 14, 2018

@maciejbocianski Correct. A fix is available for the tool, all that's left is for @ARMmbed/mbed-os-test to deploy the fix. No action from HAL needed.

/morph test

@cmonr
Copy link
Contributor

cmonr commented Sep 14, 2018

/morph test

@cmonr cmonr added the risk: G label Sep 14, 2018
@mbed-ci
Copy link

mbed-ci commented Sep 14, 2018

Test : SUCCESS

Build number : 2857
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7945/2857

@cmonr cmonr merged commit 836eec0 into ARMmbed:master Sep 14, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc3 risk: G
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@jarlamsa @0xc0170 @mbed-ci @SeppoTakalo @kjbracey @cmonr @adbridge @maciejbocianski @OPpuolitaival @mikaleppanen