-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mbedtls_platform_context parameter to NULL #7960
Conversation
Change the parameter being sent to `mbedtls_platform_setup()` and `mbedtls_platfrm_teardown()` to NULL, as it is now being unused in Mbed OS.
@RonEld Who should review these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need, in addition to these changes, a test to test out the reference counting of the resource. Two stacked setup's, followed by a crypto test operation a teardown, another test operation and a teardown, or similar.
Not a blocker - so @RonEld - can you either add that test, or create a JIRA ticket and the team can do it at a later date.
@sbutcher-arm
Created IOTSSL-2502 to track this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me on the BLE side.
/morph build |
Build : SUCCESSBuild number : 3043 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2659 |
Test : SUCCESSBuild number : 2816 |
Description
mbedtls_platform_setup()
andmbedtls_platform_teardown()
now ignore the context parameter, since #7099 was merged. Changing the sent parameter to NULL, to avoid misleading.This PR continues #7099
Pull request type