Use high resolution time for Timer::read(). #7975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
float Timer::read()
delegates toTimer::read_us()
, which returns anint
, i.e. a signed 32-bit value capable of storing values up to 2147483647 us (the use of signed types in this interface has always bothered me, but that's outside the scope of this PR). Therefore,Timer::read()
will return values up to ~2147.5f seconds, or 35.8 minutes, even though thefloat
return type could represent a much higher range (3.402823e+38 seconds, at reduced precision, of course).By contrast,
int Timer::read_ms()
returnsread_high_resolution_us() / 1000
, so the maximum (signed) value is 2147483647 ms, or more than 24 days (if I haven't made a mistake).Pull request type