Cellular: fixed crash when closing CellularNetwork via CellularDevice. #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
approved these changes
Sep 7, 2018
| @@ -29,7 +29,7 @@ namespace mbed { | |||
| class AT_CellularBase { | |||
| public: | |||
| AT_CellularBase(ATHandler &at); | |||
|
|
|||
| virtual ~AT_CellularBase() {} | |||
There was a problem hiding this comment.
Strictly not needed due to the class has no virtual members, but I guess this is a good precaution.
There was a problem hiding this comment.
how is this used (looking at the class, there's no virtual method here), that we need to have dtor virtual?
jarvte
force-pushed
the
fix_crash_in_close_cellularnetwork
branch
from
787c144
to
4ac29e9
Compare
AnttiKauppila
approved these changes
Sep 10, 2018
jarvte
force-pushed
the
fix_crash_in_close_cellularnetwork
branch
from
4ac29e9
to
ed7606b
Compare
|
/morph build |
Build : SUCCESSBuild number : 3139 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2746 |
Test : SUCCESSBuild number : 2943 |
0xc0170
approved these changes
Sep 24, 2018
|
Based on top of changes going into 5.11.0-rc1 (#7969) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATHandler was released before network instance was deleted and in network destructor athandler was used.
Internal ref to defect: IOTCELL-1321
@AriParkkila please review
Pull request type