Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF52: Ensure that we configure hardware after flow control changes #8061

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

naveenkaje
Copy link
Contributor

Call the routines to program the hardware to reflect the updates made to
flow control so that the object and hardware are in synch.

Description

During the initialization of the UART, when the flow control is set on the object, it is possible that the change does not get reflected in hardware. See attached screenshot. This change makes sure that we update the hardware registers.

discrepancy_in_settings

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Call the routines to program the hardware to reflect the updates made to
flow control so that the object and hardware are in synch.
@naveenkaje
Copy link
Contributor Author

Test code used.

#include "mbed.h"

DigitalOut led1(LED1);

int main() {
    Serial serial(USBTX, USBRX);
    serial.printf("Hello world\r\n");
    char c;
    while (true) {
        if (serial.readable()) {
			c = serial.getc();
			if (c == '\n' || c == '\r')
				serial.printf("\n\r");
			else
				serial.putc(c);
			
			/* LED Debug, to see if we are reading */
			if (c & 0x01)
				led1 = 1;
			else
				led1 = 0;
        }
    }
}

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3219
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8061/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

@NirSonnenschein
Copy link
Contributor

failure seems unrelated to PR
/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

Build : SUCCESS

Build number : 3225
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8061/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

We will restart tests once we get fixed exporters on master (will require immediate testing).

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

test queue is big, so will retry new jobs a bit later, exporters now

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants