Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISCO_L496AG : enable ADC #8168

Merged
merged 1 commit into from
Oct 8, 2018
Merged

DISCO_L496AG : enable ADC #8168

merged 1 commit into from
Oct 8, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

As described in the board User Manual, VREF+ is not connected by default to VDDA

Test

target platform_name test suite test case passed failed result elapsed_time (sec)
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_0 1 0 OK 0.32
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_1 1 0 OK 0.32
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_2 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_3 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_4 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_5 1 0 OK 0.27

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 18, 2018 12:37
@jeromecoutant
Copy link
Collaborator Author

Note for future DISCO_L496AG users:
calculation of internal channels measurements have to use this new VREFBUF_VOLTAGE_SCALE1 (i.e. 2.5V) instead of 3.3V (default VDD)

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

Note for future DISCO_L496AG users:
calculation of internal channels measurements have to use this new VREFBUF_VOLTAGE_SCALE1 (i.e. 2.5V) instead of 3.3V (default VDD)

Should this be in the commit message (higher change that someone spots this).

@jeromecoutant
Copy link
Collaborator Author

Should this be in the commit message

OK, I agree. I add also a comment in the code

@jeromecoutant
DISCO_L496AG : enable ADC
f510eff 
See User Manual, VREF+ is not connected by default

NB: Use 2.5V as reference (instead of 3.3V)
for internal channels calculation
@jeromecoutant jeromecoutant mentioned this pull request Sep 18, 2018
Open
@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Build : SUCCESS

Build number : 3267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8168/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Exporter Build : FAILURE

Build number : 2890
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8168/

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Test : SUCCESS

Build number : 3076
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8168/3076

@NirSonnenschein
Copy link
Contributor

export build failed because of a license issue - rerunning:
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Exporter Build : SUCCESS

Build number : 2897
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8168/

@cmonr cmonr merged commit 5a1c49f into ARMmbed:master Oct 8, 2018
@jeromecoutant jeromecoutant deleted the PR_ADC_DISCOL496 branch October 8, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bcostm bcostm bcostm approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeromecoutant @0xc0170 @NirSonnenschein @mbed-ci @bcostm @cmonr