New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L496AG : enable ADC #8168

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
6 participants
@jeromecoutant
Contributor

jeromecoutant commented Sep 18, 2018

Description

As described in the board User Manual, VREF+ is not connected by default to VDDA

Test

target platform_name test suite test case passed failed result elapsed_time (sec)
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_0 1 0 OK 0.32
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_1 1 0 OK 0.32
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_2 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_3 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_4 1 0 OK 0.29
DISCO_L496AG-ARM DISCO_L496AG tests-api-analogin Analog Input on AIN_5 1 0 OK 0.27

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Sep 18, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Sep 18, 2018

Note for future DISCO_L496AG users:
calculation of internal channels measurements have to use this new VREFBUF_VOLTAGE_SCALE1 (i.e. 2.5V) instead of 3.3V (default VDD)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

Note for future DISCO_L496AG users:
calculation of internal channels measurements have to use this new VREFBUF_VOLTAGE_SCALE1 (i.e. 2.5V) instead of 3.3V (default VDD)

Should this be in the commit message (higher change that someone spots this).

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Sep 18, 2018

Should this be in the commit message

OK, I agree. I add also a comment in the code

DISCO_L496AG : enable ADC
See User Manual, VREF+ is not connected by default

NB: Use 2.5V as reference (instead of 3.3V)
for internal channels calculation
@bcostm

bcostm approved these changes Sep 18, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 7, 2018

Build : SUCCESS

Build number : 3267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8168/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 7, 2018

export build failed because of a license issue - rerunning:
/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 5a1c49f into ARMmbed:master Oct 8, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 599 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9896 cycles (-30 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_ADC_DISCOL496 branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment