Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellularDevice_stub added #8176

Merged
merged 1 commit into from Sep 20, 2018
Merged

CellularDevice_stub added #8176

merged 1 commit into from Sep 20, 2018

Conversation

AnttiKauppila
Copy link

Description

Unittests are broken because of missing CellularDevice_stub.
This is added in this PR.

This is only unittest related fix, but must be prioritized

Pull request type

[ X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AnttiKauppila
Copy link
Author

@lorjala @jarvte Please review

@AnttiKauppila
Copy link
Author

@0xc0170 Please label this to next patch release. We need to get this in rapidly because unittests are broken in master

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

Unittests are broken because of missing CellularDevice_stub

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3107
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8176/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 20, 2018

Hmm, that test failure does not like it was caused by the PR.

/motph test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@AnttiKauppila
Copy link
Author

@0xc0170 @cmonr Can you merge this?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

Moved to 5.11 due to dependencies . Thanks @AnttiKauppila

@AnttiKauppila
Copy link
Author

This is dependent on #7969.
7969 should go in first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants