Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust heap size on stm32f207 #8252

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Adjust heap size on stm32f207 #8252

merged 1 commit into from
Oct 8, 2018

Conversation

juhoeskeli
Copy link
Contributor

@juhoeskeli juhoeskeli commented Sep 26, 2018

Description

The board has 128kB of RAM. Currently in mbed-os the RAM usage has increased with cloud client so that on this board the code does not fit with the current heap size. This seems to be ongoing trend that with every release the memory usage grows and the linker files need to be adjusted accordingly. Instead of adjusting the linker files and creating PR it would make sense to allow the application to configure the heap like so:

stm32f207xx.icf:

if (!isdefinedsymbol(MBED_APP_HEAP_SIZE)) {
define symbol size_heap = 0xF000;
} else {
define symbol size_heap = MBED_APP_HEAP_SIZE;
}

This PR does not implement that. I just want to hear what you think how this should be handled, because this will not be the last time adjustments are required.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@LMESTM
Copy link
Contributor

LMESTM commented Sep 26, 2018

@0xc0170 @juhoeskeli the sizing of heap and stack sizes is rather an application dependent thing. How do we want to cope with this in long term ? Could this be considered a Change Request to mbed-os to deal with this constraint ?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2018

@0xc0170 @juhoeskeli the sizing of heap and stack sizes is rather an application dependent thing. How do we want to cope with this in long term ? Could this be considered a Change Request to mbed-os to deal with this constraint ?

Yes, stack & heap should. @bulislaw / @SenRamakri please review

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

Related issue: #4067

@juhoeskeli
Copy link
Contributor Author

A change request sounds reasonable. In the meantime can we go forward with the changes in values?

@juhoeskeli
Copy link
Contributor Author

To next patch release, please.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3276
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8252/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@adbridge adbridge merged commit c8734cf into ARMmbed:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants