New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Make "file" key in notifications consistant #8276

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Sep 27, 2018

Description

2 calls to notify.cc_verbose used the a FileRef object in place of
the file's name. Other calls to notify.cc_info would use just the
file name. This PR changes these 2 calls to be consistant with the rest.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
tools: Make "file" key in notifications consistant
### Description

2 calls to `notify.cc_verbose` used the a FileRef object in place of
the file's name. Other calls to `notify.cc_info` would use just the
file name. This PR changes these 2 calls to be consistant with the rest.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change

@cmonr cmonr self-requested a review Sep 27, 2018

@cmonr cmonr added the needs: review label Sep 27, 2018

@0xc0170

0xc0170 approved these changes Oct 4, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3242
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8276/

Triggering tests

/morph test
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 6, 2018

@cmonr

cmonr approved these changes Oct 8, 2018

@cmonr cmonr merged commit 342d087 into ARMmbed:master Oct 8, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9917 cycles (-298 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment