tools: Make "file" key in notifications consistant #8276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
2 calls to `notify.cc_verbose` used the a FileRef object in place of
the file's name. Other calls to `notify.cc_info` would use just the
file name. This PR changes these 2 calls to be consistant with the rest.
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
0xc0170
approved these changes
Oct 4, 2018
|
/morph build |
Build : SUCCESSBuild number : 3242 Triggering tests/morph test |
|
/morph mbed2-build |
Test : SUCCESSBuild number : 3051 |
|
/morph export-build |
Exporter Build : FAILUREBuild number : 2847 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2850 |
cmonr
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2 calls to
notify.cc_verboseused the aFileRefobject in place ofthe file's name. Other calls to
notify.cc_infowould use just thefile name. This PR changes these 2 calls to be consistant with the rest.
Pull request type