Fix doxygen comments and spelling errors #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnotherButler
approved these changes
Oct 12, 2018
| @@ -265,7 +266,7 @@ typedef enum _mbed_module_type { | |||
| MBED_MODULE_KERNEL, | |||
| MBED_MODULE_NETWORK_STACK, | |||
| MBED_MODULE_HAL, | |||
| MBED_MODULE_NETWORK_STACKMODULE_MEMORY_SUBSYSTEM, | |||
| MBED_MODULE_MEMORY_SUBSYSTEM, | |||
There was a problem hiding this comment.
Changing the actual enum name could be breaking for someone already using it.
Please do not update this in docs
deepikabhavnani
suggested changes
Oct 12, 2018
|
@deepikabhavnani Were your requested changes fixed before this was merged? |
|
Whoops. @deepikabhavnani this small change should probably be reversed. Missed this due to the auto-merge with the rollup |
No
Yes. @SenRamakri - Please revert the enum change. It should not be part of doc change and not in patch release as well |
|
For the time being, I've marked this for 5.10.3. If the PR that fixes the enum change is ready for code freeze tomorrow, I'll bring this back in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix comments and naming in enums
Pull request type