Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up UARTSerial.cpp includes. #8489

Merged
merged 1 commit into from Oct 23, 2018
Merged

Clean up UARTSerial.cpp includes. #8489

merged 1 commit into from Oct 23, 2018

Conversation

tkem
Copy link
Contributor

@tkem tkem commented Oct 21, 2018

Description

I noticed that every driver .cpp file includes at least its corresponding header file before any device feature tests such as #if DEVICE_SERIAL, with the notable exception of UARTSerial.cpp. Even if the include is not necessary for the DEVICE macros to be present, for the sake of consistency I think UARTSerial.cpp should unconditionally include UARTSerial.h.

UARTSerial.cpp also includes <errno.h>, but apparently does not use it, so I think it's safe to remove that, too.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Nothing's broken, so I think "Refactor" describes this best (you may want to add "Code Cleanup" as an option some day).

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 22, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3436
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8489/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 23, 2018

/morph mbed2-build

@cmonr cmonr merged commit cd94443 into ARMmbed:master Oct 23, 2018
@cmonr cmonr removed the needs: CI label Oct 23, 2018
@tkem tkem deleted the fix/uartserial-include branch October 26, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants