Clean up UARTSerial.cpp includes. #8489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that every driver
.cpp
file includes at least its corresponding header file before any device feature tests such as#if DEVICE_SERIAL
, with the notable exception ofUARTSerial.cpp
. Even if the include is not necessary for theDEVICE
macros to be present, for the sake of consistency I thinkUARTSerial.cpp
should unconditionally includeUARTSerial.h
.UARTSerial.cpp
also includes<errno.h>
, but apparently does not use it, so I think it's safe to remove that, too.Pull request type
Nothing's broken, so I think "Refactor" describes this best (you may want to add "Code Cleanup" as an option some day).