-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off-by-one-error in BusIn/Out #8606
Conversation
Wow, nice catch! Out of curiosity, how did you come across this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pea-pod good catch... 👍
/morph build |
Well, it all began one day when my dad met my mom… To be honest, I saw it a while back when I was trying to teach myself C++, and learn how the mbed ecosystem worked. I really like the whole concept with mbed (especially the healthy use of python) and am glad to that I can contribute. |
/morph build |
Build : SUCCESSBuild number : 3548 Triggering tests/morph test |
Test : SUCCESSBuild number : 3332 |
Exporter Build : FAILUREBuild number : 3156 |
/morph export-build |
/morph mbed2-build |
Exporter Build : SUCCESSBuild number : 3161 |
Description
All three Bus implementation files (BusIn.cpp, BusOut.cpp, and BusInOut.cpp) contain off-by-one-errors in the subscript operator implementations.
Only 16 In/Outs exist in the array, but the MBED_ASSERT allows the 17th index through without assertion.
Also, regarding the CLA, I submitted it less than an hour ago, so I may not be in the list yet.
Pull request type