New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one-error in BusIn/Out #8606

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
6 participants
@pea-pod
Contributor

pea-pod commented Oct 31, 2018

Description

All three Bus implementation files (BusIn.cpp, BusOut.cpp, and BusInOut.cpp) contain off-by-one-errors in the subscript operator implementations.

Only 16 In/Outs exist in the array, but the MBED_ASSERT allows the 17th index through without assertion.

Also, regarding the CLA, I submitted it less than an hour ago, so I may not be in the list yet.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@cmonr

cmonr approved these changes Nov 1, 2018

@cmonr cmonr requested a review from ARMmbed/mbed-os-core Nov 1, 2018

@cmonr cmonr added the needs: review label Nov 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 1, 2018

Wow, nice catch! Out of curiosity, how did you come across this?

@deepikabhavnani

@pea-pod good catch... 👍

@cmonr cmonr added needs: CI and removed needs: review labels Nov 1, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Nov 4, 2018

/morph build

@pea-pod

This comment has been minimized.

Contributor

pea-pod commented Nov 4, 2018

Well, it all began one day when my dad met my mom…
…and that’s why I won’t go near lemurs.

To be honest, I saw it a while back when I was trying to teach myself C++, and learn how the mbed ecosystem worked.

I really like the whole concept with mbed (especially the healthy use of python) and am glad to that I can contribute.

@0xc0170

0xc0170 approved these changes Nov 5, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 5, 2018

Build : SUCCESS

Build number : 3548
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8606/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 6, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 6, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 6, 2018

@cmonr cmonr merged commit 5549c52 into ARMmbed:master Nov 6, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9948 cycles (-361 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment