New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternetSocket: Fixed missing unlock before return #8654

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@marcemmers
Contributor

marcemmers commented Nov 6, 2018

Description

Noticed I couldn't open an internetsocket any more after trying to close the socket that wasn't opened.
The mutex was still locked which was caused by a missing unlock in the close function.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Nov 6, 2018

@0xc0170

0xc0170 approved these changes Nov 7, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Nov 8, 2018

/morph build

@cmonr cmonr added the rollup PR label Nov 9, 2018

@cmonr cmonr referenced this pull request Nov 9, 2018

Merged

Rollup PR: #8686

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 9, 2018

Note: This PR is now a part of a rollup PR (#8686).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr cmonr merged commit dcb97f9 into ARMmbed:master Nov 9, 2018

14 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10199 cycles (-43 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment