Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icetea tests - update socket command client #8657

Merged
merged 1 commit into from Nov 9, 2018
Merged

Icetea tests - update socket command client #8657

merged 1 commit into from Nov 9, 2018

Conversation

michalpasztamobica
Copy link
Contributor

Description

Update of the command line client for the tests
HTTP library was added to handle TLS test.
Tiny update in TCPSOCKET_ECHOTEST_BURST_SHORT was necessary, to match new object types messages.
All icetests are passing.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , please review

@cmonr cmonr added the needs: CI label Nov 7, 2018
@NirSonnenschein
Copy link
Contributor

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2018

I aborted the build

travis-ci/astyle — Passed, 552 files (+7 files)

Please fix this for new files

@SeppoTakalo
Copy link
Contributor

@michalpasztamobica Please rebase this on top of Mbed OS master and fix the conflicts.

@michalpasztamobica
Copy link
Contributor Author

@0xc0170 astyle should be fine now.
@SeppoTakalo rebase done.

@michalpasztamobica
Icetea tests - update socket command client
c87c0ce 
Tiny update in TCPSOCKET_ECHOTEST_BURST_SHORT was necessary, to match new object types messages.
@michalpasztamobica
Copy link
Contributor Author

Passing a certificate in url is removed, as discussed. I checked that the tests are still passing fine.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

Build : SUCCESS

Build number : 3589
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8657/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

Exporter Build : SUCCESS

Build number : 3199
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8657/

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

Test : SUCCESS

Build number : 3367
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8657/3367

cmonr
cmonr reviewed Nov 9, 2018
View reviewed changes
TEST_APPS/device/socket_app/cmd_socket.cpp
static Queue<SInfo, 10> event_queue;
static int id_count = 0;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but won't let it block the PR.

Might be useful to leave a comment as to what this cert directs to.

@cmonr cmonr merged commit 00fcdb8 into ARMmbed:master Nov 9, 2018
@cmonr cmonr removed the needs: CI label Nov 9, 2018
@adbridge
Copy link
Contributor

This is sitting on top of 5.11 changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@michalpasztamobica @NirSonnenschein @0xc0170 @SeppoTakalo @mbed-ci @adbridge @cmonr