STM32L4: Add support of the new USB Device API #8665

bcostm · 2018-11-07T13:05:54Z

Description

Enable new USB Device API on the following STM32L4 platforms:

NUCLEO_L496ZG
NUCLEO_L496ZG_P
NUCLEO_L4R5ZI
DISCO_L496AG
DISCO_L475VG_IOT01A
DISCO_L476VG

The same USB HAL patch as done for STM32F4 and STM32F2 has been applied (see PRs #7322 and #8583)

Tests

tests-usb_device-basic tests are OK on ARM, IAR and GCC_ARM
tests-usb_device-serial tests are FAIL

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

adbridge · 2018-11-14T15:24:04Z

@c1728p9 This review has been waiting for 7 days could you please take a look asap

c1728p9 · 2018-11-14T20:33:57Z

targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_pcd.c

@@ -311,10 +310,10 @@ __weak void HAL_PCD_MspDeInit(PCD_HandleTypeDef *hpcd)
  */
 HAL_StatusTypeDef HAL_PCD_Start(PCD_HandleTypeDef *hpcd)
 { 
-  __HAL_LOCK(hpcd); 
+  // MBED PATCH __HAL_LOCK(hpcd); 


Why was the lock removed?

It has been removed in the F4 file so I just did the same...

c1728p9 · 2018-11-14T20:34:20Z

targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_pcd.c

-    hpcd->EPLock[index].Lock = HAL_UNLOCKED;
-
+    for (index = 0; index < hpcd->Init.dev_endpoints ; index++) { // MBED PATCH
+      hpcd->EPLock[index].Lock = HAL_UNLOCKED;


Is this just cosmetic?

0xc0170 · 2018-11-15T08:30:52Z

Note: we are currently having high load on the CI. It might take some time.

@c1728p9 this is not scheduled for 5.11 , is it?

0xc0170 · 2018-11-16T10:16:49Z

Info: This PR has been re-bundled into a new rollup PR (#8768).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

bcostm · 2018-11-16T10:47:16Z

OK. I will not add more commits here.

I will send a new PR later to align the PCD functions (Init, Start, Stop) in the F2, F4, F7 and L4 families.

cmonr · 2018-11-16T15:42:04Z

@bcostm It looks like both PRs in the last rollup PR had issues. Please take a look at the L4-related build failures: #8768 (comment)

bcostm · 2018-11-20T09:31:03Z

Rebased. I don't understand the build errors with the rollup PR for the L4 boards related to USB ? Because these boards don't have the USBDEVICE macro in targets.json. How is it possible ?

cmonr · 2018-11-22T02:20:22Z

@bcostm It's possible it was an interpretation error on my part.

Restarting CI.

screamerbg · 2018-11-22T11:01:47Z

@0xc0170 @cmonr What's the issue with this PR and CI? We're very close to feature freeze for Mbed OS 5.11 and we need to get this in (assuming it's CI issues)

bcostm · 2018-11-22T13:52:31Z

I have reproduced the build error and found the root cause. I'll send a new commit to fix it.

0xc0170 · 2018-11-22T14:13:15Z

@0xc0170 @cmonr What's the issue with this PR and CI? We're very close to feature freeze for Mbed OS 5.11 and we need to get this in (assuming it's CI issues)

This answers my question I asked a week ago above - this is targeting 5.11.

There were build problems and CI issues, we migrated to the new CI so improve. We will start CI soon (rollup PR and kvstore need to pass first , they should finish within few hours).

0xc0170 · 2018-11-24T20:40:13Z

CI started

0xc0170 · 2018-11-26T09:55:35Z

This is the build failure:

21:11:16 [MTS_DRAGONFLY_F411RE:ARM] # mbed-os-example-cellular MTS_DRAGONFLY_F411RE ARM

21:11:16 [MTS_DRAGONFLY_F411RE:ARM] UndefinedParameter: Attempt to override undefined parameter 'nsapi.default-cellular-plmn' in 'application[*]'

I do not see any change related to this. @jarvte CAn you review the failure? I looked at the cellular example, there were recent commits (related to this failure) ? Did anything break?

cmonr · 2019-01-10T21:00:56Z

sigh

And now the feature branch itself needs a rebase because of Travis CI fixes...

@bcostm Will start in a bit once the feature branch is sorted out. The TLDR is that the feature branch needs this PR (#9289) and a fix for an astyle simplification which I'm resolving now (ref: #9287 (comment)).

cmonr · 2019-01-11T06:05:52Z

Note: #7976 (comment)

0xc0170 · 2019-01-14T10:23:26Z

@c1728p9 Can you help rebasing the branch please?

This function is for USB_OTG_FS devices only. Move it in the correct place (in "#ifdef USB_OTG_FS" area).

bcostm · 2019-01-18T09:26:54Z

Rebased

0xc0170 · 2019-01-18T10:49:50Z

I restarted travis failure, and will schedule CI as soon as CI is back from updates

0xc0170 · 2019-01-18T11:34:44Z

CI restarted

mbed-ci · 2019-01-18T12:26:40Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-01-18T13:41:12Z

[DEBUG] Output: "./usb/device/targets/TARGET_STM/USBPhy_STM32.cpp", line 518: Error: #20: identifier "HAL_PCD_EP_Abort" is undefined found in the build logs, please review

bcostm · 2019-01-18T14:21:53Z

I don't understand what happens here ??? It is the same error as 10 days ago which I already resolved. Now it comes back again after a Rebase ? @jeromecoutant can you please have a look ?

jeromecoutant · 2019-01-18T14:41:38Z

targets/targets.json

@@ -3777,6 +3777,7 @@
            "TRNG",
            "FLASH",
            "QSPI",
+            "USBDEVICE",


Suggested change

"USBDEVICE",

jeromecoutant · 2019-01-21T09:33:16Z

CI restart :-)

0xc0170 · 2019-01-21T10:02:54Z

CI restarted

mbed-ci · 2019-01-22T00:14:52Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-01-22T08:43:16Z

Test restarted (CI agent failures)

0xc0170 added needs: review release-version: feature branch labels Nov 7, 2018

0xc0170 requested a review from c1728p9 November 7, 2018 13:16

jeromecoutant approved these changes Nov 7, 2018

View reviewed changes

bcostm mentioned this pull request Nov 9, 2018

STM32F7: Add support of the new USB Device API #8688

Merged

2 tasks

c1728p9 approved these changes Nov 14, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Nov 15, 2018

0xc0170 added the rollup PR: B label Nov 16, 2018

0xc0170 mentioned this pull request Nov 16, 2018

Rollup USB STM32 #8768

Closed

0xc0170 removed the rollup PR: B label Nov 16, 2018

cmonr added needs: work and removed needs: CI labels Nov 16, 2018

bcostm force-pushed the L4_feature-hal-spec-usb-device branch from 18037c6 to da471ab Compare November 20, 2018 09:27

cmonr added needs: CI and removed needs: work labels Nov 22, 2018

0xc0170 added needs: work and removed needs: CI labels Nov 26, 2018

c1728p9 force-pushed the feature-hal-spec-usb-device branch from 8b6fffb to 15f9389 Compare January 17, 2019 21:16

bcostm added 3 commits January 18, 2019 10:21

STM32L4 USB: add patch in CubeL4 hal driver

3d0fe3f

STM32L4 USB: add pins definition for STM32L496/L4R5 MCUs

4a80bea

STM32L4 USB: move HAL_PCD_EP_Abort function

9996bdc

This function is for USB_OTG_FS devices only. Move it in the correct place (in "#ifdef USB_OTG_FS" area).

bcostm force-pushed the L4_feature-hal-spec-usb-device branch from e8c5762 to 72e0a98 Compare January 18, 2019 09:22

0xc0170 added needs: work and removed needs: CI labels Jan 18, 2019

jeromecoutant reviewed Jan 18, 2019

View reviewed changes

STM32L4 USB: enable USBDEVICE

bd1c700

bcostm force-pushed the L4_feature-hal-spec-usb-device branch from 72e0a98 to bd1c700 Compare January 21, 2019 07:35

0xc0170 added needs: CI and removed needs: work labels Jan 21, 2019

0xc0170 added ready for merge and removed needs: CI labels Jan 22, 2019

0xc0170 merged commit 091b0e7 into ARMmbed:feature-hal-spec-usb-device Jan 22, 2019

0xc0170 removed the ready for merge label Jan 22, 2019

bcostm deleted the L4_feature-hal-spec-usb-device branch January 22, 2019 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32L4: Add support of the new USB Device API #8665

STM32L4: Add support of the new USB Device API #8665

bcostm commented Nov 7, 2018 •

edited

adbridge commented Nov 14, 2018

c1728p9 Nov 14, 2018

bcostm Nov 15, 2018

c1728p9 Nov 14, 2018

bcostm Nov 15, 2018

0xc0170 commented Nov 15, 2018

0xc0170 commented Nov 16, 2018 •

edited

bcostm commented Nov 16, 2018 •

edited

cmonr commented Nov 16, 2018

bcostm commented Nov 20, 2018

cmonr commented Nov 22, 2018

screamerbg commented Nov 22, 2018

bcostm commented Nov 22, 2018

0xc0170 commented Nov 22, 2018 •

edited

0xc0170 commented Nov 24, 2018

0xc0170 commented Nov 26, 2018

cmonr commented Jan 10, 2019

cmonr commented Jan 11, 2019

0xc0170 commented Jan 14, 2019

bcostm commented Jan 18, 2019

0xc0170 commented Jan 18, 2019

0xc0170 commented Jan 18, 2019

mbed-ci commented Jan 18, 2019

0xc0170 commented Jan 18, 2019

bcostm commented Jan 18, 2019

jeromecoutant Jan 18, 2019

jeromecoutant commented Jan 21, 2019

0xc0170 commented Jan 21, 2019

mbed-ci commented Jan 22, 2019

0xc0170 commented Jan 22, 2019

STM32L4: Add support of the new USB Device API #8665

STM32L4: Add support of the new USB Device API #8665

Conversation

bcostm commented Nov 7, 2018 • edited

Description

Tests

Pull request type

adbridge commented Nov 14, 2018

c1728p9 Nov 14, 2018

Choose a reason for hiding this comment

bcostm Nov 15, 2018

Choose a reason for hiding this comment

c1728p9 Nov 14, 2018

Choose a reason for hiding this comment

bcostm Nov 15, 2018

Choose a reason for hiding this comment

0xc0170 commented Nov 15, 2018

0xc0170 commented Nov 16, 2018 • edited

bcostm commented Nov 16, 2018 • edited

cmonr commented Nov 16, 2018

bcostm commented Nov 20, 2018

cmonr commented Nov 22, 2018

screamerbg commented Nov 22, 2018

bcostm commented Nov 22, 2018

0xc0170 commented Nov 22, 2018 • edited

0xc0170 commented Nov 24, 2018

0xc0170 commented Nov 26, 2018

cmonr commented Jan 10, 2019

cmonr commented Jan 11, 2019

0xc0170 commented Jan 14, 2019

bcostm commented Jan 18, 2019

0xc0170 commented Jan 18, 2019

0xc0170 commented Jan 18, 2019

mbed-ci commented Jan 18, 2019

Test run: FAILED

0xc0170 commented Jan 18, 2019

bcostm commented Jan 18, 2019

jeromecoutant Jan 18, 2019

Choose a reason for hiding this comment

jeromecoutant commented Jan 21, 2019

0xc0170 commented Jan 21, 2019

mbed-ci commented Jan 22, 2019

Test run: FAILED

0xc0170 commented Jan 22, 2019

bcostm commented Nov 7, 2018 •

edited

0xc0170 commented Nov 16, 2018 •

edited

bcostm commented Nov 16, 2018 •

edited

0xc0170 commented Nov 22, 2018 •

edited