Match enet_tasklet_disconnect() declaration to definition #8698
Conversation
The declaration of enet_tasklet_disconnect() was declared in the header to return a void. In definition, it returned int8_t. This fix is just to correct the header to match the code.
|
As you've now noted in the issue - the parameters also mismatch, so fix that too. Also, it seems the error was able to arise because ethernet_tasklet.c failed to include "include/enet_tasklet.h" Please fix that at the same time - the other tasklets have their own-header include before "include/mesh_system.h". |
|
The That does raise the question of what happened to any calls that pass |
In the earlier commit, I fixed the return code. In this fix, I added the arguments so that the signature exactly matches the function.
By including this header in the source, we are having the compiler keep the function and declaration the same.
|
As I said above, the one remaining call to this needs to pass |
the enet_tasklet_disconnect() signature is now fixed to correctly require an argument (boolean). This call (the only call) now calls the function with a boolean correctly.
I added the wrong boolean in this fixed call.
The signature said it returned uint8_t but in reality the function returned int8_t.
"mesh_connection_status_t" is not defined without the header.
The declaration of enet_tasklet_XXXX() functions was declared in the header file. Some of the declarations didn't match the definitions so those were fixed. This let to some other issues, where the calls where not called cleanly. All this was corrected and is now building cleanly.
…o elm3-patch-1
|
@elm3 Could you take a look at your last commit? Something doesn't look right with it. Whenever you do a rebase, you end up force-pushing your branch, not generating a merge commit. |
|
@elm3 ? |
|
Closing since no response/activity has occurred in over two weeks. Feel free to reopen once an update is available. |
Rework of ARMmbed#8698 Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Rework of #8698 Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Description
The declaration of enet_tasklet_disconnect() was declared in the header to return a void. In definition, it returned int8_t. This fix is just to correct the header to match the code.
Pull request type