-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wio 3G] Added default I/F type and pin defs #8701
Conversation
How was this tested? Any test results that can be shared? |
@0xc0170 Can this use for test result?
|
@AnttiKauppila @toyowata Please review this PR (adding cellular default interface) |
@ytsuboi Could you please rebase this PR? |
@adbridge rebased. |
@ytsuboi you have added merge commits to this PR rather than rebasing. Please note that we do not accept merge commits as they make backporting fixes to release branches problematic. Could you please re-do it with an actual rebase. Thanks. |
@ytsuboi We can provide assistance/instructions if needed. It's apparent that a rebase was not done, because 1) the last commit is the following "Merge remote-tracking branch 'origin/wio3g' into wio3g", and 2) this PR now contains changes that recently came into master. |
@ytsuboi Thank you that looks much better :) |
Note: This PR is now a part of a rollup PR (#8753). In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR. No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Please ignore. I derped. |
Description
Cc @toyowata
Pull request type