Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wio 3G] Added default I/F type and pin defs #8701

Merged
merged 1 commit into from
Nov 15, 2018
Merged

[Wio 3G] Added default I/F type and pin defs #8701

merged 1 commit into from
Nov 15, 2018

Conversation

ytsuboi
Copy link
Contributor

@ytsuboi ytsuboi commented Nov 10, 2018

Description

  • Added undefined pins, D19 and D20.
  • Added default interface def for Mbed OS 5.10.

Cc @toyowata

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

Added default interface def for Mbed OS 5.10.

How was this tested? Any test results that can be shared?

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Nov 12, 2018

@0xc0170 Can this use for test result?

[BOOT] Mbed Bootloader
[BOOT] ARM: 00000000000000000000
[BOOT] OEM: 00000000000000000000
[BOOT] Layout: 0 80075F0
[BOOT] Active firmware integrity check:
[BOOT] [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]
[BOOT] SHA256: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
[BOOT] Version: 1541847355
[BOOT] Slot 0 is empty
[BOOT] Active firmware up-to-date
[BOOT] Application's start address: 0x8010400
[BOOT] Application's jump address: 0x8041A69
[BOOT] Application's stack address: 0x20030000
[BOOT] Forwarding to application...

Starting Simple Pelion Device Management Client example
Connecting to the network...
Connected to the network successfully. IP address: 10.171.73.NNN
[SMCC] Autoformatting the storage.
[SMCC] Reset storage to an empty state.
[SMCC] Starting developer flow
Initialized Pelion Client. Registering...
Simulated button clicked 1 times
Simulated button clicked 2 times
Simulated button clicked 3 times
Simulated button clicked 4 times
Simulated button clicked 5 times
Simulated button clicked 6 times
Connected to Pelion Device Management. Endpoint Name: XXXXXXXXXXXX00000000000XXXXXXXXX
Simulated button clicked 7 times
Simulated button clicked 8 times

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

@AnttiKauppila @toyowata Please review this PR (adding cellular default interface)

@adbridge
Copy link
Contributor

@ytsuboi Could you please rebase this PR?

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Nov 14, 2018

@adbridge rebased.

@adbridge
Copy link
Contributor

@ytsuboi you have added merge commits to this PR rather than rebasing. Please note that we do not accept merge commits as they make backporting fixes to release branches problematic. Could you please re-do it with an actual rebase. Thanks.

@cmonr
Copy link
Contributor

cmonr commented Nov 14, 2018

@ytsuboi We can provide assistance/instructions if needed.

It's apparent that a rebase was not done, because 1) the last commit is the following "Merge remote-tracking branch 'origin/wio3g' into wio3g", and 2) this PR now contains changes that recently came into master.

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Nov 15, 2018

@adbridge @cmonr I'm so sorry for the messy rebase before. I think I could resolve, could you please check?

@adbridge
Copy link
Contributor

adbridge commented Nov 15, 2018

@ytsuboi Thank you that looks much better :)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit dad6ede into ARMmbed:master Nov 15, 2018
@cmonr cmonr removed the needs: CI label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants