-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MBED_ALL_STATS_ENABLED to config system #8761
Conversation
@kegilbert New record? Already time for a rebase 😄 |
Gah waited all day for that rollup to get in, figured I'd put this PR up now....should've waited 30 minutes. Updooted. |
5c9e1dd
to
6999e39
Compare
That makes two of us... |
Might want to check with this as well, since it'll be next: #8760 |
@kegilbert - Good work here, but I will like to wait for #8592. @lauri-piikivi - Had query if network statistics config option should be in platform or network. Also we enable all stats in 'MBED_ALL_STATS_ENABLED'. With define it is not an issue, but in case of config should it be in feature/netsocket or platform? |
platform/mbed_stats.h
Outdated
#define MBED_THREAD_STATS_ENABLED 1 | ||
|
||
#ifndef MBED_SYS_STATS_ENABLED | ||
#define MBED_SYS_STATS_ENABLED 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#define MBED_SYS_STATS_ENABLED 1 | |
#define MBED_SYS_STATS_ENABLED 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't tab the code in #ifndef #endif
. Similar change for other defines as well
@lauri-piikivi - Network statistics will be kept separate from platform statistics. Will update the network stats PR accordingly. |
@kegilbert - Looks good to me, just small changes suggested. |
346fb04
to
a31c49f
Compare
/morph build |
Build : SUCCESSBuild number : 3687 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3288 |
Test : FAILUREBuild number : 3461 |
@kegilbert Can you please rebase? |
All the PRs need to be engineering ready (marked as "needs: CI") by the end of the day (Austin time). Otherwise it won't make 5.11 and will need to come in the next release (5.12 for features, 5.11.1 for fixes and new platforms). |
@kegilbert Rebase now, or forever hold your peace. |
a31c49f
to
9117a27
Compare
9117a27
to
2a9c930
Compare
@cmonr rebased |
CI restarted. |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Add
MBED_ALL_STATS_ENABLED
to the config system. Added define guards in mbed_stats.h to both disallow accidental conflicting redefines (which will generate a warning without the new guards), and to allow:to enable all stats but the CPU ones.
May get a merge conflict with #8734 after the rollup PR gets in, will fix when we get there.
Pull request type