New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix long writes/reads stack overflowing #8802
Conversation
@ConradBraam any update for the recent review here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writes and reads queue, not overflow stack IOTPAN-295
Can you add more info to the commit msg ? What issue is this fixing and how? From the code, continue_write/read is changed to using event queue. What is a reason for this change, what should it fix (stack was overflowing ?)
+1, looks good but need a better title/commit message :) |
Are we happy with the PR description now? |
@ConradBraam I think people were referring to the commit messages themselves:
If I had to guess, the comments about the commit mesasges were about the last commit. Doing a |
Also, since the two more recent commits are single line changes, squashing the three commits into one would work as well. |
As this is not moving as it should, we should squash this while merging (1 commit with better commit message). CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
@mbed-os-test ^^ EOF exception ? Will restart |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Note for merging, this needs squashing to one commit |
Squashed and merged. |
Description
Fix stack overflow crashes if using large message. NFC EEPROM wrapper not using recursion/stack anymore. All read/write/erase command follow-on blocks are now processed in the queue for large messages, since handling these were causing stack overflows if > about 2k of data.
Pull request type