Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add radio access technology as configurable in json #8821

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 20, 2018

Added radio access technology as configurable item in cellular mbed_lib.json.

Issue: ARMmbed/mbed-os-example-cellular#87

@AriParkkila @mirelachirica please review

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested review from AriParkkila and a team November 20, 2018 14:47
@0xc0170 0xc0170 changed the title Cellular: added radio access technology as configurable in json Cellular: add radio access technology as configurable in json Nov 20, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2018

Please rebase to fix the conflict

@jarvte
Copy link
Contributor Author

jarvte commented Nov 26, 2018

@0xc0170 rebase done

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

Exporters were aborted, investigating why and possibly will restart

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

There was a linker command file failure. This will need a restart. I would suggest to move this to 5.12rc1

@cmonr
Copy link
Contributor

cmonr commented Nov 26, 2018

@0xc0170 This should come in for 5.11.0 because it's a feature change.

@cmonr
Copy link
Contributor

cmonr commented Nov 26, 2018

@jarvte Could you test this this locally and see if this is an issue? Unsure if this is a CI issue or PR issue.

http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/builds/exporter/8821/1/uvision5/FAIL/LPC54114/

@cmonr cmonr added the risk: R label Nov 26, 2018
@cmonr
Copy link
Contributor

cmonr commented Nov 27, 2018

Restarting exporter CI, just in case the last failure was a fluke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants