TARGET_MCUXpresso_MCUS: fix lp ticker init function #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when lp ticker is already initialized the ticker interrupt should be disabled.
mprse
referenced
this pull request
Nov 21, 2018
This PR provides implementation of ticker_free() function for the following boards: ARCH_PRO EV_COG_AD3029LZ EV_COG_AD4050LZ K22F K64F K82F KW24D KW41Z LPC546XX NRF51_DK NRF52_DK NUCLEO_F207ZG NUCLEO_F401RE NUCLEO_F429ZI NUCLEO_F746ZG REALTEK_RTL8195AM
0xc0170
approved these changes
Nov 21, 2018
|
CI started |
|
Looks fine to me, was this line causing a failure? |
No failure was reported, it was discovered while reviewing code for some other issue. |
mmahadevan108
approved these changes
Nov 30, 2018
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When lp ticker is already initialised, then ticker init function should only disable ticker interrupt. In current implementation
NVIC_EnableIRQ(LPTMR0_IRQn);is called incorrectly in this case.To fix this issue we will call
lp_ticker_disable_interrupt();when lp ticker is initialised.Pull request type