Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency configs to component build #8874

Closed
wants to merge 3 commits into from

Conversation

deepikabhavnani
Copy link

Description

Build dependency for components was not captured i.e. in case Network feature / RTOS is disabled (added to .mbedignore list), the build breaks. Resolving build issues in this PR.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Deepika added 3 commits November 26, 2018 15:23
"ns_types.h" is not used, but included. Results in build failure when networking
feature is ignored with .mbedignored

"mbed_trace.h" not used.
"ns_types.h" results in build failure when networking feature is ignored with
.mbedignored. ESP8266 component should be enabled only when NSAPI is present.
…present

Build failures were observed when rtos is ignored with .mbedignored.
Components dependent on RTOS should be guarded with MBED_CONF_RTOS_PRESENT
@deepikabhavnani deepikabhavnani deleted the fix_componets branch November 26, 2018 22:51
@deepikabhavnani deepikabhavnani restored the fix_componets branch November 26, 2018 22:51
@deepikabhavnani deepikabhavnani deleted the fix_componets branch November 26, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant